[WIP] [PMREQ-818] BGP EVPN Phase 1 operator changes - #5281
Draft
skoryk-oleksandr wants to merge 3 commits into
Draft
[WIP] [PMREQ-818] BGP EVPN Phase 1 operator changes#5281skoryk-oleksandr wants to merge 3 commits into
skoryk-oleksandr wants to merge 3 commits into
Conversation
Adds an EVPN block to the Installation CalicoNetworkSpec so the operator
can enable BGP EVPN feature end-to-end:
- Installation.spec.calicoNetwork.evpn = {mode, peerIP, peerASN,
localASN, maxHopLimit}. Mode is a Disabled/Enabled enum defaulting to
Disabled.
- Regenerated CRD manifests and deepcopy via 'make gen-files'.
Follow-on commits will:
- Propagate the config to Felix via FELIX_EVPN_* env vars in nodeEnvVars.
- Render a calico-bgp DaemonSet on every node when EVPN is Enabled.
- Add the shared UDS hostPath volume between calico-node and calico-bgp.
When Installation.spec.calicoNetwork.evpn.mode == Enabled: - Render a calico-bgp DaemonSet with hostNetwork=true and hostPath UDS. - Propagate FELIX_EVPN_* env vars to calico-node.
Without this, Installation.spec.calicoNetwork.evpn is silently dropped during Installation defaulting: mergeCalicoNetwork() copies each CalicoNetworkSpec field individually and had no case for the new EVPN field. Result of the miss: the operator never sets FELIX_EVPN_* env vars on calico-node and never renders the calico-bgp DaemonSet, even when the user's Installation had the EVPN block populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP / do not merge. Operator changes for BGP EVPN Phase 1 (PMREQ-818).
Companion PoC branch in
tigera/calico-private: https://github.com/tigera/calico-private/pull/13561. Design doc lives attigera/designsunder2026/PMREQ-818-bgp-evpn-research/design.md.What is included
api/v1/installation_types.go:Installation.spec.calicoNetwork.evpnAPI (EVPNSpec,EVPNModestring enum, per-cluster peer defaults).pkg/render/evpn_bgp_daemon.go: renders thecalico-bgpDaemonSet whenevpn.mode: Enabled(hostNetwork, hostPath UDS mount for/var/run/calico, TolerateAll, RollingUpdate).pkg/render/node.go: propagatesFELIX_EVPN_*env vars (SOCKET_PATH,NODE_IPviastatus.hostIPfieldRef,NODE_ASN,PEER_IP,PEER_ASN,MAX_HOP_LIMIT) onto thecalico-nodeDaemonSet.pkg/controller/installation/core_controller.go: conditionally passes the EVPN DaemonSet renderer whenMode == Enabled.pkg/controller/utils/merge.go: adds the EVPN case tomergeCalicoNetworkso the field is not stripped during Installation defaulting.Test plan
pkg/controller/utils(full package, merge regression)pkg/render(full package, render regression)calico-privatePoC branch in a kind clustercalico-bgpDaemonSet renders andFELIX_EVPN_*env vars appear oncalico-node