EV-6699: Document license agent removal in 3.24.0-3 - #3001
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
The upgrade-guide uninstall instructions hard-code a specific “upgrade-from” manifest version without clearly marking it as an example, which can mislead users upgrading from other versions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Documents the removal of the Calico Enterprise license agent in the upcoming 3.24 release line by updating release notes, platform-specific upgrade guidance, and adding redirects for the removed metrics page.
Changes:
- Added release-notes entries calling out license agent removal and an upgrade note that points to cleanup steps.
- Updated Kubernetes (Helm + Operator) and OpenShift upgrade guides with license-agent uninstall/cleanup instructions and a pointer to license metrics documentation.
- Added redirects from the removed license-agent metrics page to the license options page for
latestand3.24.
File summaries
| File | Description |
|---|---|
| static/_redirects | Adds redirects for the removed license-agent metrics page. |
| calico-enterprise/release-notes/index.mdx | Adds deprecated/removed note and upgrade note about license agent removal. |
| calico-enterprise/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx | Documents OpenShift-specific uninstall/cleanup steps for the removed license agent. |
| calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx | Documents operator-based upgrade uninstall/cleanup steps for the removed license agent. |
| calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx | Documents Helm-based upgrade uninstall/cleanup steps for the removed license agent. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
f51c254 to
04d91ac
Compare
04d91ac to
8ec2a04
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The manual fallback cleanup steps don’t account for older license-agent NetworkPolicy naming (allow-tigera tier), which can leave resources behind for users upgrading from pre-v3.23 installs without the original manifest.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
The release-note and upgrade-guide updates are only applied to unversioned “Next” docs, while the Calico Enterprise 3.24 content users will read is served from calico-enterprise_versioned_docs/version-3.24-2/ and currently lacks these updates.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
8ec2a04 to
9181a9b
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The manual cleanup commands may miss older license-agent NetworkPolicy variants (pre-3.23 tier naming), making the uninstall guidance incomplete for some upgrade paths.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Lite
9181a9b to
e52be43
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to documentation/redirect updates and the identified issues are minor formatting consistency nits with straightforward fixes.
Review details
Suppressed comments (3)
calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx:92
- This command block also lacks a language tag; consider changing the opening fence to ```bash for consistency with other blocks in this file.
**calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx:69**
* This second command block fence should also specify a language (```bash) for consistent formatting with the rest of the page.
calico-enterprise/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx:102
- This second command block fence should also specify a language (```bash) to match the rest of the upgrade guide’s command examples.
- **Files reviewed:** 5/5 changed files
- **Comments generated:** 3
- **Review effort level:** Lite
</details>
e52be43 to
9174846
Compare
9174846 to
96a89ad
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The documentation updates are consistent across release notes, upgrade paths, and redirects, and the internal links/targets resolve to existing docs pages.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
|
||
| ::: | ||
|
|
||
| ### License agent |
There was a problem hiding this comment.
Maybe clarify i the title that it has been removed.
In the paragraph, please direct them towards the operator metrics in calico-enterprise/operations/monitor/metrics/operator-metrics.mdx
There was a problem hiding this comment.
changed the title to License agent removed and updated the link to point to operator metrics instead of license metrics.
96a89ad to
7f248c0
Compare
7f248c0 to
71e9304
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation/redirect updates with verified internal links/anchors and consistent redirect paths for the configured version routing.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
71e9304 to
f321690
Compare
There was a problem hiding this comment.
🟡 Changes recommended
There are a few documentation accuracy/convention inconsistencies (release version string and OpenShift kubectl vs oc) that should be corrected before merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
calico-enterprise/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx:107
- This OpenShift upgrade guide otherwise uses
oc(for example lateroc apply ...), but these cleanup commands usekubectl. For consistency with the rest of the doc, consider usingocfor these deletions as well.
kubectl delete servicemonitor calico-lic-monitor -n tigera-prometheus --ignore-not-found
kubectl delete networkpolicies.projectcalico.org calico-system.tigera-license-agent-access -n tigera-license-agent --ignore-not-found
kubectl delete networkpolicies.projectcalico.org allow-tigera.tigera-license-agent-access -n tigera-license-agent --ignore-not-found
kubectl delete clusterrole,clusterrolebinding tigera-license-agent --ignore-not-found
kubectl delete namespace tigera-license-agent --ignore-not-found
- Files reviewed: 5/5 changed files
- Comments generated: 4
- Review effort level: Lite
There was a problem hiding this comment.
🟡 Changes recommended
The OpenShift upgrade instructions introduce kubectl commands in a guide that otherwise consistently uses oc, which is inconsistent for the target platform.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
calico-enterprise/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx:96
- This OpenShift-specific upgrade guide uses
ocelsewhere, but the new license-agent removal steps usekubectl, which is inconsistent and may be confusing for OpenShift users. Useocfor these commands in this guide.
The license agent has been removed in $[prodname] v3.24.0-3. If you previously installed
it, uninstall it using the manifest from the version you are upgrading
**from** — it is still available at its versioned URL. For example, if upgrading from v3.23.2:
```bash
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
f321690 to
a05baed
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The release-notes “platform-specific steps” link currently points to a DocCardList index rather than directly to the license-agent removal instructions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
The license agent is removed in Calico Enterprise 3.24.0-3.0 and is no longer maintained. No license-agent image is published for this release or later. - Release notes: add a "Deprecated and removed features" entry, plus an "Upgrade notes" subsection pointing to the platform-specific cleanup steps. - Upgrade guides (helm, operator, openshift): document how to uninstall the agent, preferring the versioned manifest from the release being upgraded from, with a manual resource cleanup fallback. Each links to the license metrics documentation. - Redirects: point the removed license-agent metrics page at the license options page for the latest and 3.24 paths. These are non-forced 301s, so they stay dormant while 3.23 remains latest and activate once 3.24.0-3.0 ships.
a05baed to
a35c64d
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The upgrade guides’ version string (v3.24.0-3) is inconsistent with the PR’s stated release identifier (3.24.0-3.0) and should be aligned to avoid reader confusion.
Review details
Suppressed comments (3)
calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/operator.mdx:82
- The PR description/title refer to version
3.24.0-3.0, but this section saysv3.24.0-3, which is inconsistent and could confuse readers looking for the exact release/build identifier.
The license agent has been removed in $[prodname] v3.24.0-3. If you previously installed
calico-enterprise/getting-started/upgrading/upgrading-enterprise/kubernetes-upgrade-tsee/helm.mdx:59
- The PR description/title refer to version
3.24.0-3.0, but this section saysv3.24.0-3, which is inconsistent and could confuse readers looking for the exact release/build identifier.
The license agent has been removed in $[prodname] v3.24.0-3. If you previously installed
calico-enterprise/getting-started/upgrading/upgrading-enterprise/openshift-upgrade.mdx:92
- The PR description/title refer to version
3.24.0-3.0, but this section saysv3.24.0-3, which is inconsistent and could confuse readers looking for the exact release/build identifier.
The license agent has been removed in $[prodname] v3.24.0-3. If you previously installed
- Files reviewed: 5/5 changed files
- Comments generated: 0 new
- Review effort level: Lite
ti-afra
changed the title
The license agent is removed in Calico Enterprise 3.24.0-3.0 and is no longer maintained. No license-agent image is published for this release or later.