STAFF-11: Fix CSV import success notification - #519
Closed
w196n8y-hub wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes STAFF-11 by correcting the notification shown after importing users from CSV.
Previously, the CSV import result always triggered an error alert, even when the import completed without any errors. The updated logic now shows a success alert when
num_errors === 0, while preserving the existing error alert when import errors are present.Type of change
How Has This Been Tested?
Added Vitest coverage for both CSV import result paths:
userService.query()is called after both result paths.Test command:
npm run test:ci -- --include src/app/admin/states/users/users.component.spec.tsResult:
Testing Checklist