ADR-0007: record approved GraphQL DataLoader architecture - #800
Merged
Conversation
ja573
marked this pull request as ready for review
August 11, 2026 17:27
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task identity
THOTH-GQL-ADR-0007-RECORD-01developat2bec75e6698232f7643862120e5437452fcfa252(verified unmoved at task start)docs/shared-architecture/adr-0007-dataloaderdevelopAuthority
The CTO explicitly approved the exact ADR-0007 architecture on 2026-08-11, following the independently reviewed
THOTH-GQL-DATALOADER-SPIKE-02outcome (APPROVED - B0 FEASIBLE).Approved source artifact:
ADR-0007-conventional-request-scoped-graphql-dataloader.mdApproved source SHA-256 (verified before use, exact match):
05978f9c8aa556ba7fb1d2cc6522ea075bd50c9770f9fc48cdab3a9bda0fcde7The repository copy differs from the approved
PROPOSEDartifact only in mechanical approval-state metadata: headerStatus: APPROVED+Approved by: CTO/Approval date: 2026-08-11; the headerSupersedes:conditional clause resolved toADR-0006; and the section 14 approval-state block updated toAPPROVEDwith the same metadata and tense. No architectural decision, invariant, option, rollout, rollback, evidence interpretation or implementation boundary changed (full delta shown in the review diff).This PR records the approved decision. It does not itself constitute independent approval or merge authorization.
Scope — the four authorized documentation surfaces
docs/engineering/decisions/ADR-0007-conventional-request-scoped-graphql-dataloader.md— added (exact approved content + approval-state metadata).docs/engineering/decisions/ADR-0006-request-scoped-graphql-batching.md— status metadata only:Status: SUPERSEDED,Superseded by: ADR-0007, plus a minimal factual supersession notice. Historical body preserved unchanged.docs/engineering/decisions/decision-register.md— ADR-0007 row added (APPROVED, programmes, CTO approval date, supersedes ADR-0006, authority condition, approval ≠ implementation authorization, no production activation); ADR-0006 row set to SUPERSEDED with its historical approval record preserved; a supersession pointer before the historical ADR-0006 narrative; ADR-0007 narrative appended.CHANGELOG.md— one### Changedentry under## [Unreleased].Non-goals
OFFremains the state; duplicate-mutation execution remains a separately controlled concern.Database migration: NONE·Data migration: NONE·GraphQL schema migration: NONERuntime behaviour change: NONE·Production activation: NONE·Authorization behaviour change: NONE·GraphQL request acceptance change: NONE·Deployment: NONEEvidence
origin/develop=2bec75e6698232f7643862120e5437452fcfa252at task start (unmoved from the authorized reference base; no reconciliation needed). Exact PR head reviewed:e5dbd8a641c70c7ba266dde6cf609a0c7dfebfb1.git diff --check: clean.Supersedes: ADR-0006↔ ADR-0006Superseded by: ADR-0007↔ register statuses (APPROVED/SUPERSEDED) agree; ADR numbering has no collision (ADR-0007 was unoccupied); all relative links in the changed documents resolve; the register's historical ADR-0006 narrative is explicitly marked historical.Rollout / rollback
Documentation-only control lifecycle: draft PR → fresh independent exact-head review → explicit CTO merge authorization (HIGH-risk cross-programme decision) → merge to
develop; only then does ADR-0007 become repository-authoritative. Before merge: close PR/delete branch if rejected. After merge: no history rewrite; material reversal requires a superseding ADR; factual defects use the normal bounded correction workflow.Review gate
Fresh independent exact-head review required.
Separate explicit CTO merge authorization required.