Fix Role and DelegatedRole hashing - #2973
Open
Sachith77 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sachith Reddy <sachith.24bcs10403@sst.scaler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While going through
_payload.py, I noticed thatRole.__hash__()fails because it tries to hashkeyids(a list) andunrecognized_fields(a dict) directly.This PR:
keyidsto a tuple before hashing.unrecognized_fieldssince it may contain nested, unhashable JSON.DelegatedRole.__hash__()usingself.pathinstead ofself.paths.pathsandpath_hash_prefixesto tuples before hashing.The full test suite passes locally with
tox.I noticed similar patterns in a few other metadata classes, but kept this PR focused on
RoleandDelegatedRole.