Skip to content

test: userspace: hda_dma: include sof/lib/cpu.h for PLATFORM_PRIMARY_… - #11496

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
kv2019i:202611-fix-ptl-standalone-tests
Nov 20, 2026
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
kv2019i:202611-fix-ptl-standalone-tests

Conversation

@kv2019i

@kv2019i kv2019i commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

…CORE_ID

The test uses PLATFORM_PRIMARY_CORE_ID but relied on an indirect include for its definition, which breaks the standalone test build. Include <sof/lib/cpu.h> explicitly.

…CORE_ID

The test uses PLATFORM_PRIMARY_CORE_ID but relied on an indirect include
for its definition, which breaks the standalone test build. Include
<sof/lib/cpu.h> explicitly.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the change making the HDA DMA test’s CPU-header dependency explicit.

No open issues 🎉

What changed in this PR

Makes the Zephyr userspace HDA DMA test’s header dependency explicit to address the standalone build failure.

Changes:

  • Adds <sof/lib/cpu.h> for PLATFORM_PRIMARY_CORE_ID, removing reliance on an indirect include.
File Description
zephyr/​test/​userspace/​test_intel_hda_dma.c Explicitly includes the header needed for PLATFORM_PRIMARY_CORE_ID.

Review effort: Balanced

@intel-sofci

Copy link
Copy Markdown

PR 11496: test results

Run date: 2026-11-20 11:31 UTC

Tested commit: de76de6afac763342c2e9fcf6b82da08be51d5a6

mtl pass rate lnl pass rate ptl pass rate wcl pass rate nvl pass rate

@kv2019i

kv2019i commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator Author

The Zephyr unit test fail is strange, I also see it with current main now. Submitted #11501 fix for this.

@lgirdwood
lgirdwood merged commit db09dd4 into thesofproject:main Nov 20, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants