Repository navigation
test: userspace: hda_dma: include sof/lib/cpu.h for PLATFORM_PRIMARY_… - #11496
Merged
lgirdwood merged 1 commit intoNov 20, 2026
Merged
Conversation
…CORE_ID The test uses PLATFORM_PRIMARY_CORE_ID but relied on an indirect include for its definition, which breaks the standalone test build. Include <sof/lib/cpu.h> explicitly. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
abonislawski,
dbaluta,
iuliana-prodan and
lyakh
as code owners
November 20, 2026 10:46
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change making the HDA DMA test’s CPU-header dependency explicit.
No open issues 🎉
What changed in this PR
Makes the Zephyr userspace HDA DMA test’s header dependency explicit to address the standalone build failure.
Changes:
- Adds
<sof/lib/cpu.h>forPLATFORM_PRIMARY_CORE_ID, removing reliance on an indirect include.
| File | Description |
|---|---|
zephyr/test/userspace/test_intel_hda_dma.c |
Explicitly includes the header needed for PLATFORM_PRIMARY_CORE_ID. |
Review effort: Balanced
PR 11496: test resultsRun date: 2026-11-20 11:31 UTC Tested commit: de76de6afac763342c2e9fcf6b82da08be51d5a6 |
Collaborator
Author
|
The Zephyr unit test fail is strange, I also see it with current main now. Submitted #11501 fix for this. |
lgirdwood
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…CORE_ID
The test uses PLATFORM_PRIMARY_CORE_ID but relied on an indirect include for its definition, which breaks the standalone test build. Include <sof/lib/cpu.h> explicitly.