Skip to content

audio: wov_arbiter: number enum control IDs from zero - #11492

Merged
lgirdwood merged 1 commit into
thesofproject:intel/wov-d0i3-002from
singalsu:intel_wov-d0i3-002_fid_arbiter_enum_ids
Nov 20, 2026
Merged

lgirdwood merged 1 commit into
thesofproject:intel/wov-d0i3-002from
singalsu:intel_wov-d0i3-002_fid_arbiter_enum_ids

Conversation

@singalsu

Copy link
Copy Markdown
Collaborator

The kernel numbers the enum controls of a widget from zero in topology order, and uses that index as the control ID in IPC4 control messages and notifications. The arbiter expected IDs 1 and 2 for the Phrase Detect ID and WoV Call State controls, so the kernel's Phrase Detect ID (0) was rejected and every WoV PCM failed in prepare.

Use IDs 0 and 1 to match the kernel. This also makes the control change notifications from the arbiter update the right host control.

The kernel numbers the enum controls of a widget from zero in topology
order, and uses that index as the control ID in IPC4 control messages
and notifications. The arbiter expected IDs 1 and 2 for the Phrase
Detect ID and WoV Call State controls, so the kernel's Phrase Detect ID
(0) was rejected and every WoV PCM failed in prepare.

Use IDs 0 and 1 to match the kernel. This also makes the control change
notifications from the arbiter update the right host control.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu

Copy link
Copy Markdown
Collaborator Author

@naveen-manohar Please check this patch

@singalsu
singalsu marked this pull request as ready for review November 19, 2026 11:01
@singalsu
singalsu requested a balanced review from Copilot November 19, 2026 11:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change aligning WoV host control IDs with the kernel’s zero-based numbering.

No open issues 🎉

What changed in this PR

Aligns the WoV arbiter’s host enum control IDs with the kernel’s zero-based numbering, fixing WoV PCM prepare failures and ensuring notifications target the correct host controls.

Changes:

  • Changes Phrase Detect ID and WoV Call State control IDs from 1/2 to 0/1.
  • Updates the comment to explain the kernel’s numbering convention.
File Description
src/​include/​sof/​audio/​wov_arbiter.h Uses zero-based control IDs and documents the numbering convention.

Review effort: Balanced

@intel-sofci

Copy link
Copy Markdown

PR 11492: test results

Run date: 2026-11-19 11:52 UTC

Tested commit: b5130087aec920ee79666e342a2637d683f1e689

mtl pass rate lnl pass rate ptl pass rate wcl pass rate nvl pass rate

@naveen-manohar naveen-manohar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this PR on wov-d0i3-002
DMIC-WoV doesn't work

@lgirdwood
lgirdwood merged commit 0d5dfde into thesofproject:intel/wov-d0i3-002 Nov 20, 2026
26 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants