Repository navigation
Conversation
The kernel numbers the enum controls of a widget from zero in topology order, and uses that index as the control ID in IPC4 control messages and notifications. The arbiter expected IDs 1 and 2 for the Phrase Detect ID and WoV Call State controls, so the kernel's Phrase Detect ID (0) was rejected and every WoV PCM failed in prepare. Use IDs 0 and 1 to match the kernel. This also makes the control change notifications from the arbiter update the right host control. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
@naveen-manohar Please check this patch |
singalsu
marked this pull request as ready for review
November 19, 2026 11:01
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
November 19, 2026 11:01
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the change aligning WoV host control IDs with the kernel’s zero-based numbering.
No open issues 🎉
What changed in this PR
Aligns the WoV arbiter’s host enum control IDs with the kernel’s zero-based numbering, fixing WoV PCM prepare failures and ensuring notifications target the correct host controls.
Changes:
- Changes Phrase Detect ID and WoV Call State control IDs from 1/2 to 0/1.
- Updates the comment to explain the kernel’s numbering convention.
| File | Description |
|---|---|
src/include/sof/audio/wov_arbiter.h |
Uses zero-based control IDs and documents the numbering convention. |
Review effort: Balanced
PR 11492: test resultsRun date: 2026-11-19 11:52 UTC Tested commit: b5130087aec920ee79666e342a2637d683f1e689 |
naveen-manohar
approved these changes
Nov 20, 2026
naveen-manohar
left a comment
Contributor
There was a problem hiding this comment.
without this PR on wov-d0i3-002
DMIC-WoV doesn't work
lgirdwood
merged commit Nov 20, 2026
0d5dfde
into
thesofproject:intel/wov-d0i3-002
26 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kernel numbers the enum controls of a widget from zero in topology order, and uses that index as the control ID in IPC4 control messages and notifications. The arbiter expected IDs 1 and 2 for the Phrase Detect ID and WoV Call State controls, so the kernel's Phrase Detect ID (0) was rejected and every WoV PCM failed in prepare.
Use IDs 0 and 1 to match the kernel. This also makes the control change notifications from the arbiter update the right host control.