Repository navigation
kernel/user partition, Phase 4 part 6: move kernel-only headers to sof/kernel #11487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88e8e07
kernel: add src/kernel/include for the kernel-only headers
lrgirdwo 60bb7ec
platform: move sof/platform.h to sof/kernel/platform.h
lrgirdwo 5420b30
ipc: move sof/ipc/driver.h to sof/kernel/ipc/driver.h
lrgirdwo c4ef61e
library_manager: move sof/llext_manager.h to sof/kernel/llext_manager.h
lrgirdwo aa974f2
drivers: move the sof/drivers headers to sof/kernel/drivers
lrgirdwo afc227d
lib: move regions_mm.h and vpage.h to sof/kernel/lib
lrgirdwo e009533
drivers: remove the unused dmic.h and pmc.h
lrgirdwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking (
doxygenCI failure): Updating these@reftargets (plus line 235 forplatform.h) fails in CI becausedoc/sof.doxygen.indoes not list@top_srcdir@/src/kernel/include/sofinINPUT:Note that once
@top_srcdir@/src/kernel/include/sofis added toINPUT, Doxygen also flags the stale@filepaths in the two pure-rename headers from commit 7 (WARN_AS_ERROR = FAIL_ON_WARNINGS):src/kernel/include/sof/kernel/lib/regions_mm.h:9: change@file sof/lib/regions_mm.h->@file sof/kernel/lib/regions_mm.hsrc/kernel/include/sof/kernel/lib/vpage.h:5: change@file sof/lib/vpage.h->@file sof/kernel/lib/vpage.hApplying all three makes
ninja -C docbuild docpass cleanly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
src/kernel/include/sofis now in the DoxygenINPUT, added in thesof/platform.hcommit, which creates the directory (adding it in the first commit gives a "does not exist" warning there). The@filetags ofregions_mm.handvpage.hname their new paths. The documentation build, as CI runs it, now has no warnings at any commit; before, it had the three unresolved references.