Repository navigation
Add Support for tac5272 And Codec Driver Bug Fixes - #6050
Open
niranjanhyti wants to merge 4 commits into
Open
niranjanhyti wants to merge 4 commits into
niranjanhyti wants to merge 4 commits into
Conversation
The volume doesn't get correctly updated when the volume in the mixer controls are updated to their default values as the regmap cache will not do HW write leading to unexpected behaviour. So correct them with the hardware defaults. Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
The SDCA volume registers power on at 0x9c00 (-100 dBFS in Q7.8 format) which is below the mixer control range (-72 dBFS to +6 dBFS). Write 0x0 (0 dBFS) to all volume registers on first probe so the initial HW state is within the valid range and consistent with the regmap cache. SA FU21 is already handled by the existing tac_spk_seq. Add tac_dmic_seq for SM FU113 and tac_uaj_seq for UAJ FU41/FU36. Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
niranjanhyti
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
November 19, 2026 16:05
Collaborator
|
Can one of the admins verify this patch?
|
The post port prepare callback was re-enabling the DSP algorithm by writing TAC_DSP_ALGO_STATUS_RUNNING if the algo was found not running. This is not needed as the algorithm state is managed independently of the stream prepare sequence. Remove tac_port_prep() and clear the .port_prep ops entry. Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
There was a problem hiding this comment.
🔵 Needs a closer look
Removing the only DSP status-check and re-enable path requires TI hardware/firmware validation across stream restarts and power transitions that is unavailable in this review.
No open issues 🎉
What changed in this PR
Adds TAC5272 support to the ASoC SoundWire codec driver and machine-driver helpers, alongside shared TAC5xx2 initialization fixes.
Changes:
- Registers TAC5272 with jack playback/capture and digital microphone interfaces.
- Updates volume defaults and first-time initialization, and moves common widget, route, and control registration into component probing.
- Removes the port-preparation callback that re-enabled the DSP algorithm.
| File | Description |
|---|---|
| sound/soc/sdw_utils/soc_sdw_utils.c | Adds TAC5272 codec metadata and jack/microphone DAI mappings. |
| sound/soc/codecs/tac5xx2-sdw.c | Adds TAC5272 device support and updates shared initialization and DSP handling. |
Review effort: Balanced
Collaborator
|
test this please |
bardliao
reviewed
Nov 20, 2026
| case 0x5572: | ||
| case 0x5672: | ||
| case 0x5682: | ||
| case 0x2883: |
Collaborator
There was a problem hiding this comment.
Nitpick: Would you like to sort it alphabetically? I.e. Move 0x2883 to the first place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.