You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[BUG] Soundwire Regression introduced for WARN ON check for codec conf #5620
We are testing on our CRB connecting TI codecs(4 AMPS) on SW0 instance & RT712-VB codec is connected on SW1 instance.
Using recent kernel version V6.18-rc7 version, we hit with WARN_ON codec check for codec conf as mentioned below.
'WARN_ON(codec_conf != card->codec_conf + card->num_configs);'
Further checking dmesg logs, we got below findings.
It appears that the RT712 SDCA advertises multiple functions: UAJ type 0, SmartMic type 2, and HID type 10. The legacy AMD SoundWire machine driver explicitly skips DAI type 1 for SDCA devices.
According to the dmesg logs, we observe that two RT712 endpoints are retained while one is skipped and four TAS2783 smart-amps being present. This leads to a total of six actual codec_conf entries, whereas we initially expected seven based on the endpoints. Consequently, the post-build pointer check triggers the WARN_ON for codec_conf mismatch.
As per our analysis, below patch is missing the case where endpoint doesn't exist in the DisCo table
Activity
bardliao commentedon Dec 11, 2025
@charleskeepax It seems we should check
is_sdca_endpoint_present()inasoc_sdw_count_sdw_endpoints(), too.bardliao commentedon Dec 11, 2025
Or simply subtract the endpoint that is not present. Like:
vijendarmukunda commentedon Dec 11, 2025
@bardliao : Issue got fixed after applying above mentioned changes.
vijendarmukunda commentedon Dec 12, 2025
@bardliao: Could you please push the changes for upstream review?
bardliao commentedon Dec 12, 2025
#5622 I prefer reviewing here first. :) I need @charleskeepax's feedback before submitting it upstream.
ASoC: sdw_utils: subtract the endpoint that is not present
vijendarmukunda commentedon Dec 12, 2025
I do agree.
charleskeepax commentedon Dec 12, 2025
Apologies for the delay having a look now.
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
15 remaining items
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
UPSTREAM: ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present
ASoC: sdw_utils: subtract the endpoint that is not present