chore: bump the npm-development group with 2 updates - #401
Conversation
Bumps the npm-development group with 2 updates: [@biomejs/biome](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome) and [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node). Updates `@biomejs/biome` from 2.5.8 to 2.5.11 - [Release notes](https://github.com/biomejs/biome/releases) - [Changelog](https://github.com/biomejs/biome/blob/main/packages/@biomejs/biome/CHANGELOG.md) - [Commits](https://github.com/biomejs/biome/commits/@biomejs/biome@2.5.11/packages/@biomejs/biome) Updates `@types/node` from 26.2.0 to 26.4.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@biomejs/biome" dependency-version: 2.5.11 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-development - dependency-name: "@types/node" dependency-version: 26.4.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-development ... Signed-off-by: dependabot[bot] <support@github.com>
|
Leaving this open: the update resolves cleanly, but the newer Biome version reports Clearing them means changing production code, which is past dependency maintenance — |
|
Not merging this yet: the Biome upgrade in this group turns on rules the code The rules that fire:
Clearing these needs changes to production code and tests, or a deliberate Leaving this open. |
Biome 2.5.11 adds `noUnsafeTypeAssertion`, which reports seven casts. None are suppressed; each one had a way to state the same thing that the compiler can check. In hasShapeOf: - `shape[key] as unknown` was a widening cast — it can hide nothing by construction, and an annotation says it plainly: `const spec: unknown = …`. - `Object.keys(shape) as Array<keyof T>` and `value[key as string]` both fall out of iterating `Object.entries(shape)`, where the key is a string already and the value comes along with it. - `spec as Guard<…>` and `spec as Shape<…>` become the predicates `isGuard` and `isShape`, which is the pattern this directory already uses for isRecord and isString. The recursive call no longer passes `Extract<T[K], object>` explicitly; its result is only read as a boolean, and the outer `value is T` is unaffected. In runEventQlQuery.test.ts, two rows were cast to `any` to read their fields. `assert.ok(isRecord(row))` narrows them instead, so the test now checks the shape it was previously casting away — and the two existing noExplicitAny suppressions are no longer needed either. `npm run qa` passes: tsc, biome with --error-on-warnings, and all 64 tests against real containers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8dhqV77bgg5oT5pVQdi5y
goloroden
left a comment
There was a problem hiding this comment.
All seven noUnsafeTypeAssertion findings resolved by restating the types rather than suppressing the rule; two pre-existing noExplicitAny suppressions became unnecessary along the way. Verified locally with npm run qa: tsc, biome --error-on-warnings, and 64 tests against real containers.
Bumps the npm-development group with 2 updates: @biomejs/biome and @types/node.
Updates
@biomejs/biomefrom 2.5.8 to 2.5.11Release notes
Sourced from @biomejs/biome's releases.
... (truncated)
Changelog
Sourced from @biomejs/biome's changelog.
... (truncated)
Commits
4d9c1d5ci: release (#11457)18883b7fix(html): ignore punctuation in Vue attribute casing (#11462)5c353e6feat: adds the noAstroSetHtmlDirective rule for .astro (#11322)3e5367ffeat(lint): rule noUndeclaredCustomProperties (#11191)05797b1ci: release (#11450)5f1ed34chore: add CodSpeed and Cloudflare to sponsors (#11410)2081460ci: release (#11309)6559e6cfeat: adds theuseAstroClientOnlyDirectiveValuerule for .astro files (#11299)a8798eafeat: useNamedLayer (#11377)85aac73feat(lint): addnoUnsafeTypeAssertionrule (#11221)Updates
@types/nodefrom 26.2.0 to 26.4.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions