Skip to content

Add files via upload - #785

Closed
moffd234 wants to merge 6 commits into
the-csharp-academy:mainfrom
moffd234:main
Closed

moffd234 wants to merge 6 commits into
the-csharp-academy:mainfrom
moffd234:main

Conversation

@moffd234

@moffd234 moffd234 commented Oct 8, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy TheCSharpAcademy self-assigned this Oct 9, 2026

@TheCSharpAcademy TheCSharpAcademy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moffd234 Thanks for submitting. Sorry I've accidentally marked your project as approved but theproject needs some work before approval.

While the code is well structured, hardcoding questions and answers isn't acceptable. Questions should be generated dynamically using random numbers, otherwise the wouldn't be very useful after a couple of runs. This will make the game more engaging and demonstrate better use of C# fundamentals.

💁‍♂️If you have any questions, the best way to get help is in our Discord, in the #get-help-with-projects channel.

@TheCSharpAcademy

Copy link
Copy Markdown
Collaborator

@moffd234 Project approved! 😄✅ Thanks for updating your project! You've addressed the previous feedback by implementing dynamically generated questions using Random.Shared. Great work! It's a shame you didn't complete the challenges this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. 💪

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️ Avoid unnecessary fallback values: In QuestionManager, your switch expression returns 0 for unsupported operations. Consider throwing an ArgumentException instead, so unexpected inputs don't silently produce incorrect answers.

🔍️Keep classes focused: Your IoConsole class contains several input methods that aren't used in this project. While reusable utilities can be helpful, try to avoid carrying unnecessary code into smaller applications.

🔍Your menu currently accepts lowercase options only. Consider converting input to lowercase before validation so uppercase entries are accepted too.

🔍 In the future please make sure you're not committing the bin and obj folders? I suspect at least half of the files in your PR are unnecessary:

image

These should have been picked up by the repository's .gitignore but for whatever reason it wasn't. And at the end of the day you should always check to prevent unnecessary files from being committed.

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants