Skip to content

FirstProject - #778

Closed
Abdulrahman-AladdinSobhi wants to merge 1 commit into
the-csharp-academy:mainfrom
Abdulrahman-AladdinSobhi:main
Closed

Abdulrahman-AladdinSobhi wants to merge 1 commit into
the-csharp-academy:mainfrom
Abdulrahman-AladdinSobhi:main

Conversation

@Abdulrahman-AladdinSobhi

Copy link
Copy Markdown

No description provided.

@github-actions

Copy link
Copy Markdown

🚀 Project Submitted!

Thanks for submitting your project! I will review it soon.

📋 Please check the dashboard to make sure the project is marked as Pending.

⚠️ If it's not marked as pending, submit it manually using the URL for this PR.

@TheCSharpAcademy

TheCSharpAcademy commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

@Abdulrahman-AladdinSobhi Project approved! 😄✅ ✅ It's a shame you didn't complete the other ones this time. 😟 It's always a good use of your time. But nothing stops you from revisiting the project later. 👩‍🎤

🥋And congratulations! You got your green belt!! 🟩🟩

Feedback
🔍️There are a couple of cleanup opportunities. using System.Threading.Tasks.Sources; doesn't appear to be needed, and these fields at the top are unused:

public int score = 0;
static bool running = true;

🔍Replace the long if/else operation chains with a switch. You currently determine both the calculation and the displayed symbol separately. A switch expression could make that logic more concise and easier to extend.

🔍Extract question generation into its own method. PlayGame() currently generates numbers, calculates answers, displays questions, validates input, updates the score, and records history. Breaking some of that out would give you smaller methods such as GenerateQuestion(), GetPlayerAnswer(), and DisplayResult().

🗺️I noticed that you haven't completed any of our courses yet. I suggest you try our Intro to Object Oriented Programming course next. This will close gaps in your knowledge and give you more confidence about OOP

☕If you like our roadmap, please consider buying us a coffee. We appreciate your help 🙂

Overall good work!✋🏻Looking forward to seeing your next projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants