fix: disambiguate duplicate Verso labels in MeasureTheory 1.2.2-1.4.3 - #660
Open
Chessing234 wants to merge 1 commit into
Open
fix: disambiguate duplicate Verso labels in MeasureTheory 1.2.2-1.4.3#660Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Twenty-three docstrings across nine groups shared a label: Exercise 1.2.21, Definition 1.3.5, Exercises 1.3.1(i) and 1.3.1(vi), Definition 1.3.6, Exercises 1.3.2(i) and 1.3.2(iii), Example 1.4.3 and Example 1.4.21. Each label now names the declaration it sits on - almost always / almost everywhere equal / support, real vs complex, Lebesgue vs Jordan vs null vs elementary - keeping the statement number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The remaining label collisions in the MeasureTheory sections, outside the files our other open PRs touch:
Exercise 1.2.21 (Change of variables)Definition 1.3.5AlmostAlways,AlmostEverywhereEqual,Support)Exercise 1.3.1 (i) (Unsigned linearity)Exercise 1.3.1(vi) (Compatibility with Lebesgue measure)Definition 1.3.6 (Absolutely convergent simple integral)Exercise 1.3.2 (i) ({lit}*-linearity)Exercise 1.3.2(iii) (Compatibility with Lebesgue measure)Example 1.4.3OrderTop,OrderBot)Example 1.4.21Same convention as #624: keep the statement number, name the declaration in the parenthetical. The names come from the declarations themselves, not from guesswork. Docstrings only.
Checked: no duplicate one-line docstrings remain in any of the four files, all edited lines within 100 characters.
lake buildof all four modules succeeds locally —Build completed successfully (3304 jobs). Theinfo:line it prints is a pre-existing trace atSection_1_4_3.lean:318, unrelated.Deliberately avoids Section_1_1_2 (#648), Section_1_2_0 (#649, #650), Section_1_3_2 (#647) and Section_1_4_2 (#646) so it cannot collide with them.