fix: disambiguate remaining duplicate Verso labels in Chapters 2, 5 and 9 - #658
Open
Chessing234 wants to merge 1 commit into
Open
fix: disambiguate remaining duplicate Verso labels in Chapters 2, 5 and 9#658Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
…nd 9 Twenty-one docstrings across nine groups shared a label with a sibling: Proposition 2.1.16, Proposition 2.3.6, Definition 2.3.11, Example 5.1.10, Definition 5.1.12, Definitions 5.2.3 and 5.2.6, the Example 5.5.2 API, and Examples 9.3.4 and 9.3.5. Definitions and propositions name the case in the parenthetical; the examples take part letters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The label collisions left in Chapters 2, 5 and 9 after #616, #624, #626, #634 and the Section 5.3/5.6 PRs:
Proposition 2.1.16 (recursive definitions).Proposition 2.3.6 (Multiplication preserves order)Definition 2.3.11 (Exponentiation for natural numbers)Example 5.1.10.Definition 5.1.12 (bounded sequences)Definition 5.2.3 (Eventually ε-close sequences)Definition 5.2.6 (Equivalent sequences)API for Example 5.5.2Example 9.3.4,Example 9.3.5Same convention as #624: definitions and propositions name the case in the parenthetical, examples take part letters (#634). Docstrings only.
Note on Section 2.2: it has two labels of the form
(d) (Addition preserves order). Compare with Mathlib's {name}Nat.add_le_add_right`` that differ only in the Mathlib name they cite, so they are already distinct — left alone.Checked: no duplicate one-line docstrings remain in any of the six files, all edited lines within 100 characters.
lake buildof all six modules succeeds locally —Build completed successfully (3282 jobs).