Repository navigation
docs: add VPA scaling recommendations and a wrt-vpa example - #634
Merged
jaypipes merged 5 commits intoOct 10, 2026
Merged
Conversation
Adds a VPA section to docs/scaling-recommendations.md: prerequisites, how a per-version VPA behaves, update modes for workers, the updater's --min-replicas default, and which HPA and KEDA combinations are safe. Adds examples/wrt-vpa.yaml and links the new section from the VPA example in docs/worker-resource-templates.md. Closes temporalio#630
|
|
Collaborator
|
@Sanil2108 please do sign the CLA :) |
jaypipes
requested changes
Oct 9, 2026
jaypipes
left a comment
jaypipes
left a comment
Collaborator
There was a problem hiding this comment.
Two relatively minor suggested changes, otherwise this is awesome, thank you @Sanil2108!
tomba7
reviewed
Oct 10, 2026
Co-authored-by: Tomba Leishangthem <tleishan@gmail.com>
Contributor
Author
|
@jaypipes addressed both of your comments, mind taking another look? |
jaypipes
approved these changes
Oct 10, 2026
jaypipes
left a comment
jaypipes
left a comment
Collaborator
There was a problem hiding this comment.
Awesome, thank you @Sanil2108 :)
jaypipes
enabled auto-merge (squash)
October 10, 2026 11:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
docs/scaling-recommendations.md: new "Vertical scaling with VPA" section covering prerequisites, how a per-version VPA behaves, update modes for workers, the VPA updater's--min-replicasdefault (which skips versions running one pod), and which HPA and KEDA combinations are safe.examples/wrt-vpa.yaml: one VPA per version withInPlaceOrRecreate,updatePolicy.minReplicas: 1and bounds on the recommendation.docs/worker-resource-templates.md: a link from the existing VPA example to the new section.Why?
Follow-up to #622 and #623, which added
spec.targetRefinjection for VPA.The helloworld demo sets no resource requests, so its pods are BestEffort and an in-place resize would fall back to an eviction. The example lists requests as a prerequisite for that reason. Happy to add requests to the demo in a follow-up if that's useful.
Checklist
Closes [Docs] Document VerticalPodAutoscaler support #630
How was this tested:
examples/wrt-vpa.yamlthroughvalidateWorkerResourceTemplateSpecwithVerticalPodAutoscalerin the allowed kinds: accepted. As controls, it is rejected without the allow-list entry and with a hardcodedtargetRef.targetRefinjected) against the VPA v1 CRD schema, including a check for unknown fields.Any docs updates needed?
This PR is docs only.
Picked this up per my comment on #630. Happy to close it if you already had something in progress.