Repository navigation
Add nexus handler callbacks for SANO - #1926
Draft
VegetarianOrc wants to merge 1 commit into
Draft
VegetarianOrc wants to merge 1 commit into
VegetarianOrc wants to merge 1 commit into
Conversation
VegetarianOrc
added this pull request to stack #1927
October 5, 2026 18:02
VegetarianOrc
force-pushed
the
amazzeo/nexus-handler-callbacks-client
branch
from
October 5, 2026 18:12
7a3b590 to
48b8986
Compare
VegetarianOrc
force-pushed
the
amazzeo/nexus-handler-callbacks-client
branch
from
October 5, 2026 18:43
48b8986 to
6d9c87d
Compare
This was referenced Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR currently depends on draft branch of nexus-rpc for the functionality described here: nexus-rpc/sdk-python#58.
Before merging, nexus-rpc will be released with proper version and this PR updated to use that.
What was changed
NexusClient.start_operationandNexusClient.execute_operationaccept a newcompletion_callbacksargument.temporalio.nexus.create_completion_callbackcreates aCompletionCallback. It accepts a service name and an operation name, or an on-complete operation from a service definition or a handler method. It checks that the operation takesOnCompleteRequestas input and returnsOnCompleteResponse.RawValueaccepts the output of any operation.OnCompleteRequestandOnCompleteResponsemessages of the notification service.v1.9.2-nexus-handler-callbacksdev server.Why
A caller of a standalone Nexus operation can now get the outcome of the operation in a Nexus handler. When the operation finishes, the server calls an on-complete operation on a worker for the task queue of the callback. The call contains the result or the failure, and the source context that the caller supplies.
Checklist
create_completion_callback.Yes, new docs will be added in support of the Nexus handler callbacks feature.