Repository navigation
Conversation
No PHP serialization context feature is in main, so the branch pin is not needed.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04574886a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # empty version keeps that pin. Restore the lookup once the fix ships. | ||
| php_latest="$INPUT_PHP_SDK_VERSION" | ||
| if [ -z "$php_latest" ]; then | ||
| php_latest=$(./temporal-features latest-sdk-version --lang php) |
There was a problem hiding this comment.
On ordinary pull-request and push runs where php_sdk_version is empty, this lookup routes feature-tests-php back to the released SDK even though both PHP runners load the protobuf extension (.github/workflows/php.yaml:80-85 and dockerfiles/php.Dockerfile:44-46). That release's marshaller drops repeated fields from extension-backed messages, so the existing schedule tests that call describe() (features/schedule/basic/feature.php:70-75) fail; the removed serialization-context2 pin carried this fix for the schedule suite and was not only needed by PHP serialization-context features. Keep the pin/output empty until a release containing the marshaller fix is selected, otherwise both PHP feature CI and the re-enabled PHP image job regress.
Useful? React with 👍 / 👎.
1 participant
What was changed
Why?
No PHP serialization context feature is in main, so the branch pin is not needed.
Checklist
Closes
How was this tested: