Conversation
Contributor
|
happy to approve once you sign the cla @vjymisal0 |
Author
|
Thanks @chaptersix! The CLA is signed now and the license/cla check is green, so this should be ready for another look whenever you have a moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #618
What changed?
temporal operator namespace describe(andnamespace list) in text mode now includes aNamespaceInfo.Capabilitiesrow. Previously capabilities were only visible with-o json, since JSON dumps the whole response but the text view uses a fixed field list.The value is rendered the same way as the other nested proto fields in this view (e.g.
ReplicationConfig.Clusters), as compact proto JSON. JSON output is unchanged.Checklist
Stability
-o json/-o jsonl) are treated as breaking changes (JSON output is not changed)Design
Behavior
Tests
SharedServerSuite): extendedTestOperator_NamespaceCreateListAndDescribeto check the text output contains the capabilities rowManual tests
Setup
Happy path
temporal operator namespace listshows the same row for each namespace.