Skip to content

Add resource id annotation for standalone Nexus operations #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiechenz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add resource id annotation for standalone Nexus operations #877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions temporal/api/workflowservice/v1/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1704,6 +1704,10 @@ service WorkflowService {
body: "*"
}
};
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

// DescribeActivityExecution returns information about an activity execution.
Expand Down Expand Up @@ -1736,6 +1740,10 @@ service WorkflowService {
get: "/api/v1/namespaces/{namespace}/nexus-operations/{operation_id}"
}
};
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

// PollActivityExecution long-polls for an activity execution to complete and returns the
Expand All @@ -1762,6 +1770,10 @@ service WorkflowService {
get: "/api/v1/namespaces/{namespace}/nexus-operations/{operation_id}/poll"
}
};
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

// ListActivityExecutions is a visibility API to list activity executions in a specific namespace.
Expand Down Expand Up @@ -1839,6 +1851,10 @@ service WorkflowService {
body: "*"
}
};
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

// TerminateActivityExecution terminates an existing activity execution immediately.
Expand Down Expand Up @@ -1867,7 +1883,12 @@ service WorkflowService {
//
// (-- api-linter: core::0127::http-annotation=disabled
// aip.dev/not-precedent: Activity deletion not exposed to HTTP, users should use cancel or terminate. --)
rpc DeleteActivityExecution (DeleteActivityExecutionRequest) returns (DeleteActivityExecutionResponse) {}
rpc DeleteActivityExecution (DeleteActivityExecutionRequest) returns (DeleteActivityExecutionResponse) {
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "activity:{activity_id}"
};
}

// PauseActivityExecution pauses the execution of an activity specified by its ID.
// This API can be used to target a workflow activity or a standalone activity
Expand Down Expand Up @@ -2017,6 +2038,10 @@ service WorkflowService {
body: "*"
}
};
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

// DeleteNexusOperationExecution asynchronously deletes a specific Nexus operation run (when
Expand All @@ -2025,7 +2050,12 @@ service WorkflowService {
//
// (-- api-linter: core::0127::http-annotation=disabled
// aip.dev/not-precedent: Nexus operation deletion not exposed to HTTP, users should use cancel or terminate. --)
rpc DeleteNexusOperationExecution (DeleteNexusOperationExecutionRequest) returns (DeleteNexusOperationExecutionResponse) {}
rpc DeleteNexusOperationExecution (DeleteNexusOperationExecutionRequest) returns (DeleteNexusOperationExecutionResponse) {
option (temporal.api.protometa.v1.request_header) = {
header: "temporal-resource-id"
value: "nexus-operation:{operation_id}"
};
}

rpc PollWorkflowExecutionTimeSkipping (PollWorkflowExecutionTimeSkippingRequest) returns (PollWorkflowExecutionTimeSkippingResponse) {
option (google.api.http) = {
Expand Down
Loading