Repository navigation
fix: 支持已下载的 Windows UNC 音频进入本地播放 - #249
Merged
teikengstudio merged 1 commit intoNov 11, 2026
Merged
Conversation
Aschenbath
commented
Nov 10, 2026
Aschenbath
left a comment
Contributor
Author
There was a problem hiding this comment.
作者 review(c2b2762):接受独立审阅发现的第二处问题,不能仅放开file.host;MediaKitAudioDriver现向Media传toFilePath得到的原生路径,代理HTTP仍传URI。file主机只在Windows开放,无用户信息/端口/查询/片段,检查绝对路径和可转换性。原复现另有断言要求native guard继续抛ArgumentError,正确修复后不成立,独立窗口会保持原件审计并透明适配。静态分析通过,交叉验证进行中。
Aschenbath
commented
Nov 10, 2026
Aschenbath
left a comment
Contributor
Author
There was a problem hiding this comment.
Review 回复(提交 c2b2762):已处理“仅允许 file.host 仍被 media_kit 规范化丢失主机名”的发现,MediaKitAudioDriver 先 toFilePath 再构建 Media。独立窗口在独立提交及组合 1845475 各通过 10/10 项:真实 drive/localhost H$ 成品、特殊文件名读取一致、非法 file/远端 HTTP 拒绝和真实 AudioProxy 200/206 读取。原件 SHA 未变,其旧 nativeFailure isArgumentError 断言失败单独保留;独立副本改用真实 Media.normalizeURI+磁盘字节比对。缺 libmpv-2.dll,不把录制驱动 play 当作物理解码成功。未发现新增阻断问题;静态分析通过,临时测试环境已清理。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows 共享目录已生成完整下载后,播放器原先拒绝带主机名的 file URI。现在允许可转换的 Windows UNC 文件,并向 media_kit 传入原生文件路径,避免其 URI 规范化丢失 UNC 主机名。普通本地文件和受限的本机 HTTP 音频代理继续可用。
文件 URI 仍排除用户信息、端口、查询和片段,要求绝对路径且能转换为平台文件路径。
独立提交
c2b2762和组合1845475静态分析通过,独立窗口各 10/10 项通过:真实 FFmpeg 与既有 localhost/H$ 共享成品、10 个特殊文件名的媒体库路径及内容一致性、非法 URI 拒绝、真实 AudioProxy 全量和 Range 读取。原复现脚本审计保留为 1 过 / 1 失败:旧断言要求 native guard 继续拒绝,而修复后已进入原生初始化。独立副本改为媒体库路径和文件内容验证;该测试环境缺少 libmpv-2.dll,未验证物理音频解码或实际发声。HTTP 内容为合成数据,无真实账号或扣费。
Closes #245