Repository navigation
fix: 删除无关队列项时保留当前音频加载 - #248
Merged
teikengstudio merged 1 commit intoNov 11, 2026
Merged
teikengstudio merged 1 commit into
teikengstudio merged 1 commit into
Conversation
Aschenbath
commented
Nov 10, 2026
Aschenbath
left a comment
Contributor
Author
There was a problem hiding this comment.
作者 review(312f793):在命令锁外仍捕获稳定trackId,仅trackId==current.id时_newRequest,避免撤销无关加载。锁内重新按ID定位,保留既有cursor调整、保存和较新选择保护。独立12/12已通过,最终组合1845475复验中。删除无关项仍按现有命令锁等待准备完成,不引入队列并行写入。
Aschenbath
commented
Nov 10, 2026
Aschenbath
left a comment
Contributor
Author
There was a problem hiding this comment.
Review 回复(提交 312f793):独立窗口确认原复现脚本未修改;基线 3 过 / 1 失败,独立提交和最终组合 1845475 均 12/12 通过。命令锁外捕获稳定 trackId,仅删除当前声音时撤销请求;锁内仍按 ID 重新定位。排队删除/重排、暂停/清空/切集、迟到授权未发现新增问题。当前项取消在夹具中观察到 4ms,仅属测试时序,不作原生性能结论。两种提交的静态分析通过;测试临时环境已清理,证据已归档。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
自动连播正在准备下一集时,移除后面的队列项原先会取消当前授权,留下无法起播的当前集。现在只有移除当前声音才取消它的准备;无关条目继续按稳定声音 ID 和原命令顺序删除,保留有效加载。
独立提交
312f793和组合1845475静态分析通过,独立窗口各 12/12 场景通过(原 4 + 边界 8)。覆盖删除前后项、排队删除和重排,以及移除当前、暂停、清空、切集与迟到授权。基线原场景 3 过 / 1 失败。验证使用真实队列面板、PlayerService、下载及存储,合成授权和录制驱动;未测试物理音频解码。删除无关项仍按既有串行命令等待准备完成。
Closes #243