Repository navigation
fix(workflow): keep a saved connection in its workspace - #530
Merged
Merged
Conversation
Membership is required to save, run, or inspect a workflow that uses one, including rows a run already fetched. The designer keeps fields it does not edit, and the engine refuses to listen off loopback without a token. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: dc4bdc6d-ecab-4850-bdb8-8e7da1aca628) |
Contributor
Test IDsAdded (6)
|
The suite was added without a place in the runner, so the check that every e2e file is listed failed. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 3c8b3b2c-02f0-42e5-b915-50f50a38e4d6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Membership is required to save, run, or inspect a workflow that uses one, including rows a run already fetched. The designer keeps fields it does not edit, and the engine refuses to listen off loopback without a token.
Note
High Risk
Changes authentication (engine listen binding, service token guards), authorization (workspace-scoped connection checks on save/run/read), and workflow trust (
origin); proxy allowlist and run snapshot behavior affect who can reach engine data.Overview
Keeps saved FoxSchema connections scoped to their workspace when workflows are saved, run, or inspected through the proxy: it walks linked
credentialIds, checks workspace membership vianotUsableBy, and for runs usesGET /runs/:id/snapshotso edits/deletes to the live workflow cannot hide connections already used.Fixes workflow designer data loss on load/save by carrying through fields the UI does not edit (
name,version,origin,errorHandler, pipetimeoutMs, HTTP token-refreshheaders/body) and adding compile-timeengineShapeschecks so local editor types cannot drift from@foxschema/workflow-engine/definitions. The engine refuses to promoteoriginon PUT for non-authoredworkflows; duplicate drops shared webhook paths.Hardens engine exposure and proxy surface: workflow-server won't bind off loopback without
WORKFLOW_ENGINE_TOKEN; internal mounts use a sharedengineTokenGuard; run steering endpoints are removed from the allowlist until UI exists; settings PUT validates known engine enums. Run/event streaming pushes on append (with fallback poll), and the Runs panel / debug hook resume SSE after the last loaded seq and poll only when the stream is down.Smaller fixes: trigger dialog drops dead Save/Test buttons and placeholder sections; CSV parser performance + formula-safe file sink; query API keys redacted in reported HTTP URLs; workflow list avoids loading full run history; E2E workflow-designer-roundtrip added.
Reviewed by Cursor Bugbot for commit 3129834. Bugbot is set up for automated code reviews on this repo. Configure here.