refactor(web): one view registry drives the shell (PR 3)

[huyplb]

PR 3 of the feature-architecture schedule. Nothing a user sees changes.

Before

A workspace view was wired in five places: the ActiveView union, viewLoaders.ts, App.tsx (lazy constants, a redirect effect, a ternary chain), the rail's id→view/icon/test-id maps, and uiStore's persisted-view list.

After

• app/features/viewIds.ts: the ids. It has no imports, so uiStore validates a persisted view without loading the registry.
• app/features/featureRegistry.ts: WORKSPACE_VIEWS: Record<ActiveView, …>, so TypeScript refuses a missing entry. Each entry holds:
  • its rail button (label and permission from COMMUNITY_NAV, or its own)
  • allowed and fallback
  • its lazy load
  • inside prefetch
• App.tsx renders WORKSPACE_VIEWS[activeView]; ActivityRail uses railItems; main.tsx and the rail prefetch through prefetchView. viewLoaders.ts is deleted.
• Each feature's lazy entry is view.ts (access, utilities, workflow, sql-editor, lokee-weave), never its barrel. sql-editor also has viewPane.ts, so Monaco still loads alongside the view rather than after it.
• The test-ID extractor also reads app/features/*.ts, where the rail's IDs now live as data. The catalog has the same 1717 IDs.

Tests

featureRegistry.test.ts (10), A/B-checked:

• every id is defined, shown directly or loaded
• nav ids exist in COMMUNITY_NAV
• each lazy entry is a real root-level view* file
• rail order, labels and test IDs for owner, viewer and partial roles
• every redirect: editor-only → Editor; no editor → Compare or Home; Utils and Snapshots → Home

Checks

• typecheck 0, ESLint clean, first load within the 170 KB budget.
• Full suite passes.
• Live e2e against the dev server on this branch: 36 passed, 1 skipped (smoke, lazy-loading, schema-browse, sql-editor-sqlite, access-assistant-sqlite, admin-policy, workspaces).

🤖 Generated with Claude Code

---

Note

Low Risk
Behavior-preserving shell refactor with dedicated tests for rail items and redirects; server-side authorization is unchanged.

Overview
Introduces a single workspace view registry (viewIds.ts + featureRegistry.ts) so rail buttons, lazy loaders, prefetch (inside for Monaco), and permission redirects live in one typed WORKSPACE_VIEWS map instead of scattered across App.tsx, ActivityRail, and deleted viewLoaders.ts.

App.tsx builds one lazy component per view from the registry and renders via redirectFor + a generic View wrapper, replacing the long activeView ternary chain and inline redirect useEffect. ActivityRail calls railItems(can) instead of local nav/icon/test-id maps. Features gain root view.ts (and sql-editor viewPane.ts) lazy entries; Compare moves into SyncWorkspace.tsx, settings into SettingsView.tsx.

uiStore imports ActiveView / isActiveView from viewIds (no registry load on persist). E2E test IDs for rail workspace buttons are attributed to featureRegistry in the extractor and docs. featureRegistry.test.ts locks rail order, visibility, and redirects to match the old shell.

^{Reviewed by Cursor Bugbot for commit 2e6fc5c. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 0ed88397-0112-4c9f-863b-e7a6ec06116c)