feat(workspaces): public and private workspaces (D2)

[huyplb]

D2 of the workspaces plan, the last of the series. Stacked on #495 (D6) → #494 → #493 → #492 → #491.

What changes

• Workspace settings → Who can find it: Private, invite only and hidden (the default), or Public, listed to every signed-in account, which can join it. Going public asks first, because joiners use its saved connections.
• Join role: viewer (default) or editor, never owner, so a stranger joining cannot remove the owners and archive it.
• Profile menu → Browse public workspaces → Join switches into it. Already-joined, private, archived and personal workspaces are never listed, and joining one answers 404.
• Public → private keeps the members and hides it from everyone else. Personal workspaces stay private.
• PATCH /api/workspaces/:id takes visibility and joinRole; new GET /api/workspaces/discover and POST /api/workspaces/:id/join (contract table 134 → 136).
• The plan is marked built, with a list of where it differs.

Tests

• Directory tests (+6): private is hidden and unjoinable; public is listed with its join role; join gives that role and is idempotent; back to private keeps members and hides; personal stays private; settings need workspace.settings; values are checked (owner refused); archived is neither listed nor joinable. A/B: private-joinable, personal-may-go-public and discover-lists-private each fail.
• Component tests: browse → join → switch, empty list, visibility + join role (viewer/editor only), no change without confirming, no visibility section for personal workspaces or viewers.
• e2e workspaces.test.ts 8/8 against the dev server: the owner makes the workspace public in settings; a second throwaway account (editor account) finds it under Browse, joins as viewer, has no editor.ddl there, and sees the shared connection; back to private keeps it and hides it from others.
• Full suite 6042 passed.

Review

Fixed: an owner join role, going public with no confirmation, the join role being cut off by long names.

🤖 Generated with Claude Code

---

Note

Medium Risk
Changes who can join workspaces and at what role, exposing saved connections to any signed-in user when public; join role is capped at editor but membership and permission boundaries still need careful review.

Overview
Adds public workspaces so owners can list a team workspace to every signed-in user and let them self-join, with a configurable join role (viewer or editor only).

Backend: PATCH /api/workspaces/:id now accepts visibility and joinRole via updateSettings (rename folded in). New GET /api/workspaces/discover and POST /api/workspaces/:id/join add members at the workspace’s join role; private, personal, archived, and already-joined workspaces are excluded or return not found. Personal workspaces cannot go public.

UI: Workspace settings (Who can find it) for owners includes a visibility select with a confirmation when going public, plus join-role when public. The profile menu adds Browse public workspaces with list/join and switches workspace after join.

Tests & docs: Directory, component, and e2e coverage for the full flow; HTTP contract count 134→136; workspaces plan marked built; new test IDs.

^{Reviewed by Cursor Bugbot for commit 743677f. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: a9c5b604-2829-4b23-8381-882e4db4ff60)

[github-actions]

Test IDs

Added (8)

• workspace-menu-browse
• workspace-menu-public
• workspace-menu-public-empty
• workspace-menu-public-join-{…}
• workspace-menu-public-{…}
• workspace-settings-join-role
• workspace-settings-visibility
• workspace-settings-visibility-select

{…} is a part filled in at run time. The full tree: docs/testing/TEST_IDS.md.

[cursor]

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 8b4cbbe8-a664-4ead-9c52-7515fc781190)