Repository navigation
fix(gitleaks): report scans blocked by tool setup failures - #51
Merged
Merged
Conversation
GitHub Actions Integration
✅ All 1 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Background
When mise or Gitleaks installation fails, the secret scan never runs. The job fails, but its existing scan-result reporting steps are skipped, leaving no explanation in the job summary.
🔗 Related Issues
⚙️ Description
Add
Report tool setup failurewithid: setup-failure. On tool-setup failure, write a “Secret Scan Not Run” job summary and an error annotation explaining that no scan result is available and pointing to the setup logs and a rerun after resolving the installation error.The setup step remains fatal. The report runs with
failure(); subsequent normal scan steps are skipped by their implicitsuccess()condition, and the job remains failed. Post-job cleanup can still run.🚨 To Reviewers