Skip to content

PAC-950 Add compatibility with PHP 8.4 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svizevv merged 2 commits into from
Oct 24, 2025
Merged

PAC-950 Add compatibility with PHP 8.4 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a26f00
PAC-950 Add compatibility with PHP 8.4
svizevv Sep 18, 2025
629e890
PAC-950 Update dependencies
svizevv Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
# Version 23.1.0

## Features

### PHP 8.4 Compatibility

* Add PHP 8.4 support

# Version 23.0.0

## Features
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "MIT",
"require": {
"php": "^8.1",
"techdivision/import": "^18.0.0"
"techdivision/import": "^18.1"
},
"require-dev": {
"doctrine/dbal": "^4.0.4",
Expand Down
2 changes: 1 addition & 1 deletion src/Callbacks/CreateMultiselectOptionValueCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ protected function getUniqueIdentifier()
*
* @return mixed The modified value
*/
public function handle(AttributeCodeAndValueAwareObserverInterface $observer = null)
public function handle(?AttributeCodeAndValueAwareObserverInterface $observer = null)
{

// set the observer
Expand Down
2 changes: 1 addition & 1 deletion src/Callbacks/CreateSelectOptionValueCallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ protected function getUniqueIdentifier()
*
* @return mixed The modified value
*/
public function handle(AttributeCodeAndValueAwareObserverInterface $observer = null)
public function handle(?AttributeCodeAndValueAwareObserverInterface $observer = null)
{

// set the observer
Expand Down
10 changes: 5 additions & 5 deletions src/Observers/AttributeOptionObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,15 @@ class AttributeOptionObserver extends AbstractAttributeImportObserver implements
* Initializes the observer with the passed subject instance.
*
* @param \TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface $attributeBunchProcessor The attribute bunch processor instance
* @param \TechDivision\Import\Observers\AttributeLoaderInterface $attributeLoader The attribute loader instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\AttributeLoaderInterface|null $attributeLoader The attribute loader instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface|null $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance to use
*/
public function __construct(
AttributeBunchProcessorInterface $attributeBunchProcessor,
AttributeLoaderInterface $attributeLoader = null,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?AttributeLoaderInterface $attributeLoader = null,
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// initialize the bunch processor, the attribute loader and the entity merger instance
Expand Down
8 changes: 4 additions & 4 deletions src/Observers/CatalogAttributeObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,15 @@ class CatalogAttributeObserver extends AbstractAttributeImportObserver
* Initializes the observer with the passed subject instance.
*
* @param \TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface $attributeBunchProcessor The attribute bunch processor instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface|null $entityMerger The entity merger instance
* @param \TechDivision\Import\Loaders\LoaderInterface|null $headerMappingLoader The loader for the virtual mappings
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance to use
*/
public function __construct(
AttributeBunchProcessorInterface $attributeBunchProcessor,
EntityMergerInterface $entityMerger = null,
LoaderInterface $headerMappingLoader = null,
StateDetectorInterface $stateDetector = null
?EntityMergerInterface $entityMerger = null,
?LoaderInterface $headerMappingLoader = null,
?StateDetectorInterface $stateDetector = null
) {

// initialize the bunch processor and the entity merger instance
Expand Down
6 changes: 3 additions & 3 deletions src/Observers/EntityAttributeObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,13 @@ class EntityAttributeObserver extends AbstractAttributeImportObserver
* Initializes the observer with the passed subject instance.
*
* @param \TechDivision\Import\Attribute\Services\AttributeBunchProcessorInterface $attributeBunchProcessor The attribute bunch processor instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\EntityMergers\EntityMergerInterface|null $entityMerger The entity merger instance
* @param \TechDivision\Import\Observers\StateDetectorInterface|null $stateDetector The state detector instance to use
*/
public function __construct(
AttributeBunchProcessorInterface $attributeBunchProcessor,
EntityMergerInterface $entityMerger = null,
StateDetectorInterface $stateDetector = null
?EntityMergerInterface $entityMerger = null,
?StateDetectorInterface $stateDetector = null
) {

// initialize the bunch processor and the entity merger instance
Expand Down
Loading