Repository navigation
Conversation
jcristau
force-pushed
the
fetch-content-markers
branch
from
October 29, 2026 19:07
a2bb9c0 to
25c9c9a
Compare
When MOZ_RESOURCE_MONITOR_FORWARD is set, append a marker covering the download and extraction of each fetch to it, using the forwarding protocol of mozsystemmonitor, so that a resource monitor started by run-task's startup hook shows them in its profile. Fetches run in parallel threads, and other processes may forward to the same file, so open it the way mozsystemmonitor does: on Windows, O_APPEND isn't atomic, so use a handle that may only append instead.
jcristau
force-pushed
the
fetch-content-markers
branch
from
November 4, 2026 15:29
ead6459 to
90850af
Compare
jcristau
marked this pull request as ready for review
November 4, 2026 15:29
hneiva
approved these changes
Nov 4, 2026
hneiva
left a comment
hneiva
left a comment
Contributor
There was a problem hiding this comment.
just one question, not really a block.
| """Open path for writes that are each appended atomically, even when | ||
| several processes append to it concurrently.""" | ||
| if sys.platform != "win32": | ||
| return os.open(path, os.O_WRONLY | os.O_APPEND) |
Contributor
There was a problem hiding this comment.
aka: brace yourselves... here comes some wonky windows stuff
| if bool(gpg_sig_url) != bool(gpg_env_key): | ||
| print("--gpg-sig-url and --gpg-key-env must both be defined") | ||
| return 1 | ||
| with fetch_marker(args.url): |
Contributor
There was a problem hiding this comment.
Would it be useful to break down this into multiple markers?
It's downloading the gpg_sig_url, then the url, then repack. Would we ever want more granularity for this marker?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When MOZ_RESOURCE_MONITOR_FORWARD is set, append a marker covering the download and extraction of each fetch to it, using the forwarding protocol of mozsystemmonitor, so that a resource monitor started by run-task's startup hook shows them in its profile.