You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The deno job has been red since the watch test learned to spawn #27
npm run test:deno fails on main and has since #22 landed:
error: NotCapable: Requires run access to "/opt/hostedtoolcache/deno/2.9.5/x64/deno", run again with the --allow-run flag
at NodeTestContext.<anonymous> (test/progress.test.mjs:226:28)
FAILED | 354 passed | 1 failed | 8 ignored
a watch does not hold the program open is the only test in the suite that spawns a child process, and it has to: a watch nobody stopped is a timer that keeps the loop alive, and the only way to ask whether a program exited is to be a different program. Deno refuses a spawn unless the permission is named, and test:deno names read, write, env and ffi but not run.
So the test never ran under Deno. It is not a Deno incompatibility and nothing about the addon is wrong there. With --allow-run added to the command, the whole suite is 355 passed, 0 failed, 8 ignored on deno 2.9.5, and the watch test takes 123 ms, so it really did spawn and the child really did exit.
Granting run is not a widening worth worrying about next to --allow-ffi, which is already there and is the permission that lets the addon exist at all.
Activity