fixed issue that prevented mouse wheel from scrolling multiline tabs - #428
Open
redyoshi49q wants to merge 1 commit into
Open
fixed issue that prevented mouse wheel from scrolling multiline tabs#428redyoshi49q wants to merge 1 commit into
redyoshi49q wants to merge 1 commit into
Conversation
It's possible that this entire code block could be removed without negative repercussions, so long as an XML element with the box-inherit and scrollbox-innerbox classes always exists regardless of configuration settings. I have not dug into the code to check whether or not this is the case, so I added a second exception for not returning null for multi-line tab configs.
Member
|
I think I need some code comment above the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had been experiencing an issue in my browser setup where the tab bar could be vertically scrolled by clicking and dragging the scroll bar, but doing the same was not possible via the mouse wheel.
I eventually diagnosed this issue as stemming from the Tabkit extension; the section of code that handles tab bar scrolling relies on a variable that's set to null for configurations other than tab tree mode, and with a null value for that variable, the error checking logic that includes this line gets triggered. I added in additional logic to set this variable to a non-null value for multiline tab mode as well, which lets the tab bar scroll correctly.
It's possible that this entire code block could be removed without negative repercussions, so long as an XML element with the box-inherit and scrollbox-innerbox classes always exists regardless of configuration settings. I have not dug into the code to check whether or not this is the case.