make tabs fill up tab bar space in multiline mode - #427
Open
redyoshi49q wants to merge 1 commit into
Open
Conversation
A few variable declarations were moved to the beginning of the relevant function so that they would be in scope in appropriate places (such as the function call to set the value used for the minimum tab width in the CSS).
Member
|
OK let's run this for ~ a month and if no issue I will cut a release tabkit2_0.15.0-2026-08-06-114151.xpi.zip Or maybe you have run this on your own browser for some time already? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...Hi. It's me again.
This should resolve issue #160 . I've tested the changes with a multiline tab bar setup, and from the looks of things, the section of code I tweaked shouldn't get executed for other configurations.
A few variable declarations were moved to the beginning of the relevant function so that they would be in scope in appropriate places (such as the function call to set the value used for the minimum tab width in the CSS).
The code accounts for the size of tab borders, but a constant value (found by inspecting the chrome of the Pale Moon browser with the browser dev tools) gets used for that rather than a value derived from the browser environment itself. This could result in incorrectly sized tabs (and a return of the gap to the right of tabs that this commit attempts to address) for specific browser window widths on environments that have different configurations for their tabs (such as other web browsers, browsers running other extensions that affect the tabs, or other versions of Pale Moon that change the default appearance of tabs).
Also, the tab width resizing seems to slightly lag behind the horizontal resizing of the tab bar. I'm not sure whether making this behavior snappier is plausible or not.