Fix invalid truncation of multipart responses - #54
Merged
Merged
Conversation
There is a bug in the multipart response generator, unnecessarily truncating the response while indexing response chunks relative to the original chunk size. Additionally, wrap parts in memoryviews to avoid creating temporary objects when assembling chunks from part slices. Add missing unit tests for multipart responses and adjust existing tests to align with valid HTTP method/body semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the multipart response generator, unnecessarily
truncating the response while indexing response chunks relative
to the original chunk size.
Additionally, wrap parts in memoryviews to avoid creating temporary
objects when assembling chunks from part slices.
Add missing unit tests for multipart responses and adjust existing
tests to align with valid HTTP method/body semantics.