Fix CSRF vulnerability in session-based authentication - #53
Merged
Merged
Conversation
Require valid CSRF tokens for HTTP sessions. Currently, CSRF tokens are only required for HTTP Basic Authentication. However, session cookies are equally vulnerable to CSRF attacks as they are sent automatically by the browser. Add new regression tests to ensure that session cookies can only authenticate when a valid CSRF token and cookie is sent by the client.
Update load testing results related to authentication and session management for the security fix delivered in 7dde64e.
Include CSRF security fix and documentation updates in the v0.9.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require valid CSRF tokens for HTTP sessions. Currently,
CSRF tokens are only required for HTTP Basic Authentication.
However, session cookies are equally vulnerable to CSRF
attacks as they are sent automatically by the browser.
Add new regression tests to ensure that session cookies
can only authenticate when a valid CSRF token and cookie
is sent by the client.