Add browser security hardening and unsafe content handling - #46
Merged
Merged
Conversation
Add default safe CSP (Content Security Policy) headers to control resource loading and browser execution behavior. Serve unsafe content types under /www/user_data as attachments, and prevent such resources being rendered by browsers. Add missing content type mappings for common media types to improve browser interoperability. Remove /lib/pyrobusta from the default configuration of served paths.
Until now, 'http_auth_mode' controlled if CSRF protection is enabled. This commit assigns enabling and disabling browser security headers to the same config key and renames it from 'http_auth_mode' to 'browser_security'. The type of the config changes from string to boolean.
This change addresses issues found during static analysis: - hide methods for finalizing headers as it is not meant to be used by user applications; this also fixes a violation of max number of public methods - update methods for applying patches, requiring the class as an argument to avoid circular imports in optional HTTP modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add default safe CSP (Content Security Policy) headers to control resource loading and browser execution behavior.
Serve unsafe content types under /www/user_data as attachments, and prevent such resources being rendered by browsers.
Add missing content type mappings for common media types to improve browser interoperability.
Remove /lib/pyrobusta from the default configuration of served paths.