Optimize imaging spectrum bin accumulation - #792
Merged
YukiMatsuzawa merged 1 commit intoSep 7, 2026
Conversation
Replace repeated dictionary lookups with TryGetValue in the imaging spectrum binning hot path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
YukiMatsuzawa
deleted the
copilot/yukimatsuzawa-performance-hotspot-fix-e2b
branch
September 7, 2026 07:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainsKey/indexer lookups with a singleTryGetValuein the imaging spectrum binning hot pathPerformance rationale
Each incoming peak previously performed a dictionary membership lookup and then additional indexer lookups. The new code performs one lookup and reuses the retrieved bin, reducing hash-table work and indexer overhead for every accumulated peak.
Performance improvement candidates identified
DisplayScans.Containschecks.ToListbefore consumers that accept enumerables.Validation
DataAccessTestspassed.MsdialCorebuild passed after restore; restore reported existing package vulnerability/compatibility warnings.