jextract: fail on missing or empty javaPackage (#919) - #921
Open
bhanage-viraj wants to merge 1 commit into
Open
bhanage-viraj wants to merge 1 commit into
bhanage-viraj wants to merge 1 commit into
Conversation
…x JNI symbol naming for empty package (swiftlang#919)
Author
|
@ktoso This pull request is ready for review |
Collaborator
|
Thanks, some national holidays over here the next days, will review as soon as I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jextractno longer treats a missing/emptyjavaPackageas success and emitpackage ;.SwiftToJava.run()now requires a non-empty package before analysis or any generated output, for both JNI and FFM.--java-packagestays optional so the value can still come fromswift-java.config/ the build plugin. Surrounding whitespace is rejected rather than trimmed; empty segments (com..foo) are rejected. The unnamed/default package is not implemented.Fixes jextract accepts an empty javaPackage and emits invalid Java source in JNI and FFM modes #919
Test plan
swift test --filter JavaPackageValidationTests(nil, empty, whitespace, empty segments, valid package unchanged;SwiftToJava.run()for nil and"")swift test --filter InputSwiftTests(validjavaPackagestill generates)--java-package '', omitted--java-package, and--mode ffmall fail with the missing-package error and write no output--java-package com.example.myswiftlibrarystill succeeds and emitspackage com.example.myswiftlibrary;