Skip to content

Use the new LTS Android NDK alone for both testing packages and for workflow pulls here - #315

Open
finagolfin wants to merge 1 commit into
swiftlang:mainfrom
finagolfin:ndk
Open

finagolfin wants to merge 1 commit into
swiftlang:mainfrom
finagolfin:ndk

Conversation

@finagolfin

Copy link
Copy Markdown
Member

No description provided.

@finagolfin
finagolfin requested a review from a team as a code owner September 10, 2026 11:27
@finagolfin

Copy link
Copy Markdown
Member Author

LTS NDK 30 is now the only supported one, but keep the older ones around until we ship a Swift 6.4 SDK built with NDK 30 and the GitHub CI have installed it in their runners.

@marcprux and @justice-adams-apple, please review.

@marcprux marcprux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@finagolfin

Copy link
Copy Markdown
Member Author

@shahmishal, easy review

type: string
description: "The NDK versions to use when building with the Swift SDK for Android"
default: "[\"r27d\", \"r28c\"]"
default: "[\"r27d\", \"r28c\", \"r30\"]"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop 27?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have no problem dropping anything before 30, as these are only the defaults and devs can always specify what they want.

If you prefer some other default, just let me know.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop 27 and 28 from default

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I only kept the old ones around for the default because we still supported 6.3, built with NDK 27, when I submitted this pull adding NDK 30 last week. Now that 6.4 is out, built with NDK 30, and all prior NDKs are unsupported, this is the right default.

@finagolfin finagolfin changed the title Add the new LTS Android NDK testing to packages and for workflow pulls here Use the new LTS Android NDK alone for both testing packages and for workflow pulls here Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants