Repository navigation
Fix graceful shutdown - #252
Merged
Merged
Conversation
AsyncSocket.close now removes socket from pool
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 93.79% 93.74% -0.06%
==========================================
Files 72 72
Lines 3820 3837 +17
==========================================
+ Hits 3583 3597 +14
- Misses 237 240 +3 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncSocket.close() is now
asyncand removes socket from pool resuming waiting suspensions.fixes #251
Similar to the solution offered by @lhoward in #250
Graceful shutdown of
HTTPServer.stop()now ends immediately after all connections are drained and the listening socket is closed.