fix: resolve inherited C++ members from DWARF - #293
Merged
Conversation
Traverse non-virtual inheritance DIEs and flatten base layouts with adjusted offsets. Preserve derived-member precedence, reject ambiguous multiple-inheritance lookups, and follow DWARF 5 type-unit signatures emitted by Clang and GCC. Add unit and end-to-end coverage for inherited lookup, ambiguity, and signature-backed base types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test -p ghostscope-dwarf --all-featurescargo test -p ghostscope-e2e-tests --test dwarf_index_regressions test_gdb_index_resolves_function_type_and_global_lazily -- --nocapturetest_cpp_member_access_after_many_sibling_blocks_compilestest_cpp_inherited_member_accesstest_cpp_ambiguous_inherited_member_access_is_rejectedA full host e2e run was also attempted. Unrelated Rust value tests failed with the same invalid-read output on the baseline in this environment. Container-topology e2e was not run because this change does not affect container behavior.