Skip to content

Declare tvOS and test real expression evaluation - #3

Merged
yusuftor merged 1 commit into
mainfrom
feat/tvos
Nov 5, 2026
Merged

yusuftor merged 1 commit into
mainfrom
feat/tvos

Conversation

@yusuftor

@yusuftor yusuftor commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Adds .tvOS(.v15) to Package.swift platforms. The tvOS slices come from superwall/superscript 1.0.18 (PR linked below).
  • Replaces the empty placeholder test with three that evaluate expressions through the binary: matching, non-matching, and an invalid expression that returns an error rather than crashing.

Merge order

Merge this before the superscript PR. That PR bumps the crate to 1.0.18, which triggers this repo's release workflow. The workflow pulls main before writing the new binary URL, so the 1.0.18 tag will then include tvOS. Until 1.0.18 is out, declaring tvOS only matters to someone building this package for tvOS, which fails either way.

The CocoaPods podspec stays iOS and macOS, so the trunk lint doesn't change.

Testing

  • swift test passes on macOS against the published 1.0.17 binary.
  • Against a locally built 1.0.18 xcframework: the tests pass on the watchOS 10 simulator. A watch app and a tvOS app depending on SuperwallKit build and link for device and simulator. There's no tvOS simulator runtime on this machine, so tvOS was only built and linked, not run.

Part of watchOS and tvOS support in SuperwallKit (superwall/Superwall-iOS#594).

🤖 Generated with Claude Code

The 1.0.18 xcframework from superwall/superscript adds tvOS slices, so the
package can declare tvOS. Merge this before that release: the release
workflow pulls main before writing the new binary URL, so the tag includes
the platform.

Replaces the empty placeholder test with ones that evaluate a matching,
a non-matching and an invalid expression through the binary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant