Repository navigation
fix(catalog): don't discard the snapshot on an orphaned catalog row - #844
Closed
gintsgints wants to merge 2 commits into
Closed
gintsgints wants to merge 2 commits into
gintsgints wants to merge 2 commits into
Conversation
A `pg_proc` row whose namespace no longer exists made the `functions` query return a null schema, which failed to decode and discarded the entire snapshot - disabling every database-backed feature instead of only the functions. Join the namespace, language, trigger function and trigger table as inner joins so orphaned catalog rows are skipped, and load everything but schemas, tables, columns and the version leniently: a failure is logged and yields an empty list. Typing metadata is marked incomplete when any of the objects type inference relies on failed to load, so it keeps reporting only what Postgres would certainly reject. Fixes supabase-community#842 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Author
|
Please consider this as draft only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
pg_procrow whose namespace no longer exists made thefunctionsquery return a null schema, which failed to decode and discarded the entire snapshot - disabling every database-backed feature instead of only the functions.Join the namespace, language, trigger function and trigger table as inner joins so orphaned catalog rows are skipped, and load everything but schemas, tables, columns and the version leniently: a failure is logged and yields an empty list. Typing metadata is marked incomplete when any of the objects type inference relies on failed to load, so it keeps reporting only what Postgres would certainly reject.
Fixes #842
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.