Repository navigation
fix(window): expose SDL move resize fallback outside X11 - #111
Merged
sudoevolve merged 1 commit intoOct 21, 2026
Merged
Conversation
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Closes #110. Windows SDL2 builds fail with C3861 in beginWindowMove/beginWindowResize because the helper definition is accidentally inside the outer Linux/X11 resource guard. The helper already has a non-X11 false fallback.
修改
Move the outer guard end before the helper; keep the existing platform branches and public API. Add null-window rejection checks to window_only_probe. This is the prerequisite for the independent transparency repair in #109, not a new window capability.
影响
本机环境
Windows 11 build 26200 x64; Intel Core i9-12900H; NVIDIA RTX 3070 Ti Laptop GPU (driver 32.0.15.9174); OrayIddDriver also present. MSVC 19.44.35214, Windows SDK 10.0.26100.
验证
The four independent build directories configured, built in Release and ran full CTest locally. The final combined working tree is bcfaa2e (this prerequisite f052729 plus the separately reviewed GLFW repair); SDL2 paths do not compile that GLFW repair.
platform_dialog remains its pre-existing opt-in skip. transparent_cache_probe is explicitly N/A (skip 77) except Win32 GLFW/OpenGL. The skips are not claimed as passes.
Vulkan validation uses official Khronos Vulkan-Headers v1.4.328, official glslang 16.6.0 and the installed vulkan-1.dll (MSVC import library generated from its exports), entirely under an untracked local build directory. No SDK/runtime is installed or changed. Configure sets Vulkan_INCLUDE_DIR, Vulkan_LIBRARY and Vulkan_GLSLANG_VALIDATOR_EXECUTABLE explicitly. Build commands: cmake -S . -B -DEUI_WINDOW_BACKEND=<glfw|sdl2> -DEUI_RENDER_BACKEND=<opengl|vulkan> -DEUI_BUILD_APPS=OFF -DEUI_BUILD_TEST_FIXTURES=ON -DEUI_ENABLE_TRAY=OFF -DEUI_ENABLE_MODULES=OFF; cmake --build --config Release --parallel 6; ctest --test-dir -C Release --output-on-failure.