Skip to content

fix(window): expose SDL move resize fallback outside X11 - #111

Merged
sudoevolve merged 1 commit into
sudoevolve:devfrom
Linductor-alkaid:codex/windows-sdl-move-guard
Oct 21, 2026
Merged

sudoevolve merged 1 commit into
sudoevolve:devfrom
Linductor-alkaid:codex/windows-sdl-move-guard

Conversation

@Linductor-alkaid

Copy link
Copy Markdown
Contributor

问题

Closes #110. Windows SDL2 builds fail with C3861 in beginWindowMove/beginWindowResize because the helper definition is accidentally inside the outer Linux/X11 resource guard. The helper already has a non-X11 false fallback.

修改

Move the outer guard end before the helper; keep the existing platform branches and public API. Add null-window rejection checks to window_only_probe. This is the prerequisite for the independent transparency repair in #109, not a new window capability.

影响

  • Modified 2 files, added 6 lines, removed 1; tracked content net +243 bytes.
  • No new dependencies, resources, generated files or runtime worker.

本机环境

Windows 11 build 26200 x64; Intel Core i9-12900H; NVIDIA RTX 3070 Ti Laptop GPU (driver 32.0.15.9174); OrayIddDriver also present. MSVC 19.44.35214, Windows SDK 10.0.26100.

验证

The four independent build directories configured, built in Release and ran full CTest locally. The final combined working tree is bcfaa2e (this prerequisite f052729 plus the separately reviewed GLFW repair); SDL2 paths do not compile that GLFW repair.

  • GLFW + OpenGL: Release build; 35 passed, 1 skipped out of 36, zero failures.
  • SDL2 + OpenGL: Release build; 34 passed, 2 skipped out of 36, zero failures.
  • GLFW + Vulkan: Release build; 34 passed, 2 skipped out of 36, zero failures.
  • SDL2 + Vulkan: Release build; 34 passed, 2 skipped out of 36, zero failures.
  • Related transparent_window_viewer fixtures launched and inspected on all four combinations; foreground/input requests exercised. SDL2 reports its documented false transparency capability. Actual transparency is verified for the affected GLFW/OpenGL path; no SDL2 or Vulkan alpha guarantee is claimed.
  • window_only_probe calls the public null-window move/resize rejection path in SDL2; targeted tests re-run after the final probe update.

platform_dialog remains its pre-existing opt-in skip. transparent_cache_probe is explicitly N/A (skip 77) except Win32 GLFW/OpenGL. The skips are not claimed as passes.

Vulkan validation uses official Khronos Vulkan-Headers v1.4.328, official glslang 16.6.0 and the installed vulkan-1.dll (MSVC import library generated from its exports), entirely under an untracked local build directory. No SDK/runtime is installed or changed. Configure sets Vulkan_INCLUDE_DIR, Vulkan_LIBRARY and Vulkan_GLSLANG_VALIDATOR_EXECUTABLE explicitly. Build commands: cmake -S . -B -DEUI_WINDOW_BACKEND=<glfw|sdl2> -DEUI_RENDER_BACKEND=<opengl|vulkan> -DEUI_BUILD_APPS=OFF -DEUI_BUILD_TEST_FIXTURES=ON -DEUI_ENABLE_TRAY=OFF -DEUI_ENABLE_MODULES=OFF; cmake --build --config Release --parallel 6; ctest --test-dir -C Release --output-on-failure.

@sudoevolve
sudoevolve merged commit 78659fe into sudoevolve:dev Oct 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants