Repository navigation
test(render): cover strided RGBA frames with transparent alpha - #107
Merged
sudoevolve merged 1 commit intoOct 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改内容与原因
关联 Mirage
EUI-20261013-001;关闭 #106。RGBA8/BGRA8 目标指针推进已由 #97 合入 dev。本 PR 复用该根因修复,给现有 image_stream 测试补齐旧单像素/紧凑行测试未覆盖的边界:
检查使用显式 if/return,Release 的 NDEBUG 不会移除本 PR 新增断言。不新增公共 API、生产代码、依赖或媒体。
根因与影响范围
旧版 RGBA/BGRA 转码循环没有逐列推进 destination,最后一列覆盖行首。透明右边缘导致角色整幅消失,转换仍返回 true。本 PR 覆盖通用 CPU fallback 的行 stride/alpha 契约,不包含 Mirage 产品策略。
实际测试
Ubuntu 24.04 / Linux 7.0.0-38-generic x86_64,Intel Core Ultra 5 225H,内存 32 GB,GCC 13.3.0,Mesa 软件 OpenGL / Vulkan lavapipe(未使用物理 GPU),私有 Xvfb X11。
四个独立目录均使用 Release、EUI_BUILD_TEST_FIXTURES=ON,完整配置/构建通过;全量 ctest(含 GPU image/frame presentation 等实际窗口 probe)结果:
测试命令采用 xvfb-run,并明确移除 WAYLAND_DISPLAY、设置 XDG_SESSION_TYPE=x11 与 SDL_VIDEODRIVER=x11。最初未隔离宿主 Wayland 环境时 GLFW 的 frame_presentation_probe/shadertoy_probe 失败;保留失败记录,明确 X11 后四组合全量通过。没有跳过失败测试或改探针。
独立 -O2 -DNDEBUG 编译:当前版本 exit0;三种故障注入(缺 destination 推进、忽略 row stride、强制 alpha255)均 exit1,证明测试能发现回归。
范围限制:Xvfb / 软件 GPU 结果不是物理 compositor、硬件 GPU 或 Windows 实机验收。
仓库体积
修改 1 文件;新增/删除文件 0;+35/-0 行。追踪内容净增长 1764 字节;无新增依赖、资源、生成物。低于 CONTRIBUTING.md 的 500 行 / 100 KiB 预审门槛。