fix: handle 1D input in test_stump (closes #1160) - #1170
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Closed
fix: handle 1D input in test_stump (closes #1160)#1170botbikamordehai2-sketch wants to merge 1 commit into
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
|
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1170 |
|
❌ This pull request has been automatically closed because the mandatory PR template was removed or not filled out. Please reopen or recreate this PR with the required information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The test data includes a 1D array, but
test_stumpmay assume 2D input. The snippet already guards withif T.ndim > 1, but the issue likely stems from the test data's 1D case causing dimension mismatch elsewhere. To be safe, convert 1D to 2D initially or add an assert.Fix
Ensure the test handles 1D input explicitly by keeping it as is when 1D. The current code is correct in that regard, but I'm adding a comment for clarity. If the actual failing test is elsewhere, this change won't fix it. The issue may be a false positive or needs more info.
Closes #1160