Repository navigation
docs: update vue-privacy to 2.0.2 and wire the preference centre - #669
Conversation
- Update @structured-world/vue-privacy to 2.0.2. - The banner's "Customize" button opened nothing: the site never mounted ConsentPreferenceModal. It is now mounted beside the banner. - The site measures visits only, so it declares usedCategories: ['analytics']; marketing and functional are no longer offered or granted by "Accept all". Closes #668
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Linked Issues check |  |
PR #668 requires vue-privacy 2.0.2, usedCategories: ['analytics'], and a mounted ConsentPreferenceModal. The reviewed changes update packages/gitlab-mcp/package.json from ^2.0.1 to ^2.0.2 an… |
| Out of Scope Changes check | |
The reviewed changes are limited to the docs site's vue-privacy dependency and consent configuration. The dependency update, analytics-only category declaration, modal mount, and related comment updat… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Description Check | |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly summarizes the two main changes: updating @structured-world/vue-privacy to 2.0.2 and wiring the preference centre. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a68744da5a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Once a visitor had chosen, nothing on the site reopened the preference centre, so consent could not be reviewed or withdrawn. A "Cookie settings" button now opens it on every page. - The search, download and outbound link events were never sent: the trackers called useConsent() from event handlers, where it cannot inject the consent manager, and the error was swallowed. The trackers are now bound to the manager in the tracker component's setup. Checked on the built site: the button opens the preference centre, and an outbound click with analytics allowed reaches the data layer (it did not before).
|
@codex review |
|
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
@structured-world/vue-privacy2.0.2 and its preference centre works.Changes
@structured-world/vue-privacyto 2.0.2.ConsentPreferenceModalbeside the banner, so the banner's "Customize" opens the preference centre (it opened nothing before).usedCategories: ['analytics']: the site measures visits only, so marketing and functional are neither offered nor granted by "Accept all". vue-privacy limits every stored and restored choice to these categories, so earlier choices need no new consent version.useConsent()could not inject it and those events were never sent.Testing
ad_*signal denied, and an outbound click with analytics allowed reaches the data layer.mainas well (theclosing_issuesandremoveLabelIdsintegration tests and the pool test reading timeouts from.env.test); feat(settings): add per-account settings, native settings page and connection panel #662 fixes them.Closes #668