better document StripeObject's to_dict behavior - #1879
Merged
Conversation
xavdid
changed the title
StripeObject's to_dict behavior
xavdid
marked this pull request as ready for review
August 18, 2026 22:38
xavdid
requested review from
jar-stripe and
zacchua-stripe
and removed request for
a team and
jar-stripe
August 18, 2026 22:38
xavdid
enabled auto-merge (squash)
August 18, 2026 22:39
zacchua-stripe
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
While the transition away from
dictas the base class forStripeObjecthas gone well, there have been a few small papercuts using the new objects that we could improve. Specifically, we could steer users towards the correct method if they try to use aStripeObjectas a dict.This PR doesn't raise errors where there weren't any before, but it does provide better guidance in the error messages.
What?
See Also
StripeObjectdidn't inherit fromdict? #1454StripeObjectno longer inherits fromdict#1762