fix(tempo): always bind payments to the challenge memo - #28
Closed
raubrey-stripe wants to merge 1 commit into
Closed
fix(tempo): always bind payments to the challenge memo#28raubrey-stripe wants to merge 1 commit into
raubrey-stripe wants to merge 1 commit into
Conversation
A method-wide explicit memo skipped challenge binding, so one settled transfer could satisfy every equivalent challenge. Require the MPP attribution memo on every path, including when a merchant memo is set. Co-authored-by: Cursor <cursoragent@cursor.com> Committed-By-Agent: cursor
Contributor
Author
|
Closing; this is only an issue when a server sets its own explicit memo that replaces a challenge-bound memo that's auto created by the SDK. This issue exists today in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TempoMethod.Builder.memo()is method-wide, so distinct challenges A and B advertised the same memo and the first presenter of a matching hash won.Builder.memo()cannot satisfy that binding; omit it unless the advertised memo is unique per challenge. This is the invariant issue 25 needs before replay claims can expire.Test plan
./gradlew testmemo is not bound to this challengeMade with Cursor