Skip to content

fs: Tell resize.f2fs to stop asking questions - #1221

Merged
vojtechtrefny merged 1 commit into
storaged-project:masterfrom
vojtechtrefny:master_f2fs-resize-yes
Nov 4, 2026
Merged

vojtechtrefny merged 1 commit into
storaged-project:masterfrom
vojtechtrefny:master_f2fs-resize-yes

Conversation

@vojtechtrefny

@vojtechtrefny vojtechtrefny commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Added the -F option when resizing with resize.f2fs version 1.17.0 or newer. Older versions and versions that cannot be checked continue without it.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The F2FS resize path checks whether resize.f2fs is version 1.17.0 or newer. When it is, the command includes -F. Existing safe-resize and target-size argument handling remains unchanged.

Changes: F2FS resize

Layer / File(s) Summary
Version-dependent resize option
src/plugins/fs/f2fs.c
bd_fs_f2fs_resize checks the resize.f2fs version and adds -F for version 1.17.0 or newer. The argument array expands to hold the option.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: Minimal · up to 415d1

The change conditionally suppresses resize prompts while preserving existing resize arguments. No actionable merge-blocking defect was identified; normal validation remains appropriate.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding a non-interactive option to resize.f2fs for supported versions.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 6cef17e and 415d128.

Files selected for processing: 1
  • src/plugins/fs/f2fs.c

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@vojtechtrefny
vojtechtrefny merged commit d09fd04 into storaged-project:master Nov 4, 2026
46 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants