Repository navigation
Conversation
201d78c to
efed704
Compare
|
Many thanks for the PR. I have reviewed it, and I have no feedback on the code itself apart from the one in the review comment. I would, however, redo the tests. Currently, the approach to testing a similar feature is to create a wrapper socket-like object over the real WebSocket and alter behavior as needed. I will not like to introduce another code pattern. Since you used AI to generate the test cases, please regenerate the test file based on https://github.com/stomp-js/stompjs/blob/develop/spec/unit/heart-beat.spec.ts If any of my remarks are unclear, please let me know. |
|
should be g2g! one thing i didnt address are the duration for which the timer fires. I may send a subsequent refinement PR after this. The hb duration is ~ |
Summary
Closes #755
Validation
Unit tests only