Skip to content

rewrite block.js in ES2020 with recommended style #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stklcode merged 1 commit into from
Aug 8, 2026
Merged

rewrite block.js in ES2020 with recommended style #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,16 @@ import wordpress from '@wordpress/eslint-plugin';
import globals from 'globals';

export default [
...wordpress.configs.custom,
...wordpress.configs.es5,
...wordpress.configs.recommended.map( ( config ) => ( {
...config,
files: [ 'scripts/block.js' ],
} ) ),

...wordpress.configs.es5.map( ( config ) => ( {
...config,
files: [ 'scripts/liveticker.js' ],
} ) ),

...wordpress.configs.i18n,
...wordpress.configs.jsdoc,
{
Expand Down
239 changes: 119 additions & 120 deletions scripts/block.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,37 @@
*
* Gutenberg Block to integrate the liveticker widget without shortcode.
*/
( function() {
var __ = wp.i18n.__;
var registerBlockType = wp.blocks.registerBlockType;
var registerStore = wp.data.registerStore;
var withSelect = wp.data.withSelect;
var el = wp.element.createElement;
{
const __ = wp.i18n.__;
const registerBlockType = wp.blocks.registerBlockType;
const registerStore = wp.data.registerStore;
const withSelect = wp.data.withSelect;
const el = wp.element.createElement;

/**
* Datastore actions.
*/
var actions = {
setTickers: function( tickers ) {
const actions = {
setTickers(tickers) {
return {
type: 'SET_TICKERS',
tickers: tickers,
tickers,
};
},
getTickers: function( path ) {
getTickers(path) {
return {
type: 'RECEIVE_TICKERS',
path: path,
path,
};
},
};

registerStore( 'scliveticker/ticker', {
reducer: function( state, action ) {
if ( undefined === state ) {
registerStore('scliveticker/ticker', {
reducer(state, action) {
if (undefined === state) {
state = { tickers: null };
}
switch ( action.type ) {
switch (action.type) {
case 'SET_TICKERS':
state.tickers = action.tickers;
return state;
Expand All @@ -44,35 +44,37 @@
return state;
},

actions: actions,
actions,

selectors: {
receiveTickers: function( state ) {
receiveTickers(state) {
return state.tickers;
},
},

resolvers: {
receiveTickers: function() {
return wp.apiFetch( { path: '/wp/v2/scliveticker_ticker' } ).then( function( tickers ) {
return actions.setTickers( tickers.map( function( t ) {
return {
name: t.name,
slug: t.slug,
};
} ) );
} );
receiveTickers() {
return wp
.apiFetch({ path: '/wp/v2/scliveticker_ticker' })
.then((tickers) =>
actions.setTickers(
tickers.map((t) => {
return {
name: t.name,
slug: t.slug,
};
})
)
);
},
},
} );
});

registerBlockType( 'scliveticker/ticker', {
title: __( 'Liveticker', 'stklcode-liveticker' ),
registerBlockType('scliveticker/ticker', {
title: __('Liveticker', 'stklcode-liveticker'),
icon: 'rss',
category: 'widgets',
keywords: [
__( 'Liveticker', 'stklcode-liveticker' ),
],
keywords: [__('Liveticker', 'stklcode-liveticker')],
attributes: {
ticker: {
type: 'string',
Expand All @@ -91,125 +93,122 @@
// implicit default: 'desc', left empty here for backwards compatibility of the block
},
},
edit: withSelect( function( select ) {
edit: withSelect((select) => {
return {
tickers: select( 'scliveticker/ticker' ).receiveTickers(),
tickers: select('scliveticker/ticker').receiveTickers(),
};
} )( function( props ) {
var label = [
el(
wp.components.Dashicon,
{ icon: 'rss' },
),
__( 'Liveticker', 'stklcode-liveticker' ),
})((props) => {
const label = [
el(wp.components.Dashicon, { icon: 'rss' }),
__('Liveticker', 'stklcode-liveticker'),
];
var content;
if ( null === props.tickers ) {
let content;
if (null === props.tickers) {
// Tickers not yet loaded.
content = [
el(
'span',
{ className: 'components-base-control label' },
label,
label
),
el( wp.components.Spinner ),
el(wp.components.Spinner),
];
} else if ( 0 === props.tickers.length ) {
} else if (0 === props.tickers.length) {
// No tickers available.
content = [
el(
'span',
{ className: 'components-base-control label' },
label,
label
),
el(
'span',
null,
__('No tickers available', 'stklcode-liveticker')
),
el( 'span', null, __( 'No tickers available', 'stklcode-liveticker' ) ),
];
} else {
// Tickers loaded and available.
if ( 0 === props.attributes.ticker.length && props.tickers.length > 0 ) {
props.attributes.ticker = props.tickers[ 0 ].slug;
if (
0 === props.attributes.ticker.length &&
props.tickers.length > 0
) {
props.attributes.ticker = props.tickers[0].slug;
}
content = [
el(
wp.components.SelectControl,
{
label: label,
value: props.attributes.ticker,
options: props.tickers.map( function( t ) {
return {
value: t.slug,
label: t.name,
};
} ),
onChange: function( val ) {
props.setAttributes( { ticker: val } );
},
el(wp.components.SelectControl, {
label,
value: props.attributes.ticker,
options: props.tickers.map((t) => {
return {
value: t.slug,
label: t.name,
};
}),
onChange(val) {
props.setAttributes({ ticker: val });
},
),
el(
wp.components.TextControl,
{
label: __( 'Number of Ticks', 'stklcode-liveticker' ),
type: 'number',
min: 1,
step: 1,
disabled: props.attributes.unlimited,
value: props.attributes.limit,
onChange: function( val ) {
props.setAttributes( { limit: Number( val ) } );
},
}),
el(wp.components.TextControl, {
label: __('Number of Ticks', 'stklcode-liveticker'),
type: 'number',
min: 1,
step: 1,
disabled: props.attributes.unlimited,
value: props.attributes.limit,
onChange(val) {
props.setAttributes({ limit: Number(val) });
},
),
el(
wp.components.CheckboxControl,
{
label: __( 'unlimited', 'stklcode-liveticker' ),
checked: props.attributes.unlimited,
onChange: function( val ) {
props.setAttributes( { unlimited: val } );
},
}),
el(wp.components.CheckboxControl, {
label: __('unlimited', 'stklcode-liveticker'),
checked: props.attributes.unlimited,
onChange(val) {
props.setAttributes({ unlimited: val });
},
),
el(
wp.components.SelectControl,
{
label: __( 'Output direction', 'stklcode-liveticker' ),
value: props.attributes.sort,
options: [
{
value: 'desc',
label: __( 'newest first', 'stklcode-liveticker' ),
},
{
value: 'asc',
label: __( 'oldest first', 'stklcode-liveticker' ),
},
],
onChange: function( val ) {
props.setAttributes( { sort: val } );
}),
el(wp.components.SelectControl, {
label: __('Output direction', 'stklcode-liveticker'),
value: props.attributes.sort,
options: [
{
value: 'desc',
label: __(
'newest first',
'stklcode-liveticker'
),
},
{
value: 'asc',
label: __(
'oldest first',
'stklcode-liveticker'
),
},
],
onChange(val) {
props.setAttributes({ sort: val });
},
),
}),
];
}

return el(
'div',
{ className: props.className + ' components-placeholder' },
content,
);
} ),
save: function( props ) {
return el(
'div',
{
className: 'sclt-ajax',
'data-sclt-ticker': props.attributes.ticker,
'data-sclt-limit': props.attributes.unlimited ? 0 : props.attributes.limit,
'data-sclt-last': 0,
'data-sclt-sort': props.attributes.sort,
},
content
);
}),
save(props) {
return el('div', {
className: 'sclt-ajax',
'data-sclt-ticker': props.attributes.ticker,
'data-sclt-limit': props.attributes.unlimited
? 0
: props.attributes.limit,
'data-sclt-last': 0,
'data-sclt-sort': props.attributes.sort,
});
},
} );
}() );
});
}
4 changes: 2 additions & 2 deletions scripts/liveticker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
);
}
t.updating = false;
} catch ( e ) {
} catch {
// eslint-disable-next-line no-console
console.warn( 'Liveticker AJAX update failed, stopping automatic updates.' );
}
Expand Down Expand Up @@ -249,7 +249,7 @@
try {
// eslint-disable-next-line no-eval
eval( script.innerHTML );
} catch ( e ) {
} catch {
// eslint-disable-next-line no-console
console.warn( 'Failed to evaluate embedded script.' );
}
Expand Down
Loading